fix RemoveUnusedImportsStep leftovers

[Pankraz76]

depends on:

• Use palantir-java-format as default formatter in RemoveUnusedImportsStep diffplug/spotless#2541

ref:

• fix RemoveUnusedImportsStep leftovers google/google-java-format#1262

fix #1261

implementation fixed by reliable contributor @iddeepak

Thanks for this initiative.

• fix RemoveUnusedImportsStep leftovers google/google-java-format#1262
• fix RemoveUnusedImportsStep leftovers google/google-java-format#1262 (comment)

before: 14 issues:

now: 10 issues:

[palantirtech]

Thanks for your interest in palantir/palantir-java-format, @Pankraz76! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[changelog-app]

Generate changelog in changelog/@unreleased

Type (Select exactly one)

• Feature (Adding new functionality)
• Improvement (Improving existing functionality)
• Fix (Fixing an issue with existing functionality)
• Break (Creating a new major version by breaking public APIs)
• Deprecation (Removing functionality in a non-breaking way)
• Migration (Automatically moving data/functionality to a new system)

Description

RemoveUnusedImportsTest

Check the box to generate changelog(s)

• Generate changelog entry

[iddeepak]

palantir-java-format/palantir-java-format/src/main/java/com/palantir/javaformat/java/RemoveUnusedImports.java

Line 348 in f537f78

RangeSet<Integer> fixedRanges = TreeRangeSet.create();

fixedRanges is not used ? @Pankraz76

[Pankraz76]

fixedRanges is not used ? @Pankraz76

as no (mutation) test coverage imposed, of course not. Whole branch makes no sense in this case:

• palantir-java-format/palantir-java-format/src/main/java/com/palantir/javaformat/java/RemoveUnusedImports.java

  Line 363 in f537f78

  if (!replaceWith.isEmpty()) {

Good catch!

Invalidated by push of c10069a

[Pankraz76]

issue: formattingWithoutImportOrdering() com.palantir.javaformat.java.FormatterTest

[Pankraz76]

fixes empty line issue, added this test case to import tests as well, as important. Good that we have tests.