Skip to content

bump spotless to version to 7.2.1#1384

Merged
bulldozer-bot[bot] merged 3 commits intodevelopfrom
finlayw/bump-spotless
Jul 31, 2025
Merged

bump spotless to version to 7.2.1#1384
bulldozer-bot[bot] merged 3 commits intodevelopfrom
finlayw/bump-spotless

Conversation

@FinlayRJW
Copy link
Contributor

@FinlayRJW FinlayRJW commented Jul 29, 2025

Before this PR

See baseline PR palantir/gradle-baseline#3197

We where seeing a bug where using spotless 6.22.0 and scalafmt would error:

A problem occurred configuring root project 'foundry-spark-root'.
> A problem occurred configuring project ':foundry-spark'.
   > You need to add a repository containing the '[org.scalameta:scalafmt-core_2.12:3.6.1]' artifact in 'foundry-spark/build.gradle'.
     E.g.: 'repositories { mavenCentral() }'

I believe this was due to spotless not being lazy enough / fully supporting configuration cache - this was fixed in version 7.0.0

After this PR

Use the latest version of spotless to fix the bug.

==COMMIT_MSG==
bump spotless to version to 7.2.1
==COMMIT_MSG==

Possible downsides?

The update order is important, if we release this before baseline then it wont merge and visa versa I think the best order is:

  • Release this version of PJF
  • update baseline to bump the version of spotless and set this version of PJF as the minimum

This will mean that the update to this version of PJF will be blocked unless you have the new version of baseline but the update of baseline wont be blocked as it will contain the correct minimum version of PJF

@changelog-app
Copy link

changelog-app bot commented Jul 29, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

bump spotless to version to 7.2.1

Check the box to generate changelog(s)

  • Generate changelog entry

@CRogers
Copy link
Contributor

CRogers commented Jul 31, 2025

👍

@bulldozer-bot bulldozer-bot bot merged commit 389b692 into develop Jul 31, 2025
9 checks passed
@bulldozer-bot bulldozer-bot bot deleted the finlayw/bump-spotless branch July 31, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants