feature: Allow setting 'skip reflowing long strings' in IntelliJ plugin#1462
Open
andreweacott wants to merge 3 commits intopalantir:developfrom
Open
feature: Allow setting 'skip reflowing long strings' in IntelliJ plugin#1462andreweacott wants to merge 3 commits intopalantir:developfrom
andreweacott wants to merge 3 commits intopalantir:developfrom
Conversation
Member
|
Thanks for your interest in palantir/palantir-java-format, @andreweacott! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
✅ Successfully generated changelog entry!Entry generated via PR titleTo modify this entry, edit PR title using proper format. 📋Changelog Preview✨ Features
|
|
@palantirtech Can someone please review and merge this? We have been waiting for more than 3 months now. The Intellij plugin is broken! |
Add overloaded constructors to BootstrappingFormatterService and NativeImageFormatterService that accept the old parameter lists without JavaFormatterOptions. These new constructors use default formatter options internally, maintaining backward compatibility while allowing new code to pass custom options. This eliminates the API/ABI break detected by revapi while keeping the feature support for configuring the skip-reflowing-long-strings option in the IntelliJ plugin. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
andreweacott
force-pushed
the
idea-plugin-skip-reflowing-strings-option
branch
from
71e71fe to
1443511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The core formatter supports a 'skip reflowing long strings' option but this couldn't be selected in the IntelliJ plugin settings.
After this PR
The plugin settings UI now has an option to skip reflowing long strings (which is respected by formatters).
Possible downsides?
Related Issues
Address Issue #1452