feature: IntelliJ plugin supports projects inside WSL2 (wsl/linux jdk). Fixes #899#1624
Open
KaiFieger wants to merge 1 commit intopalantir:developfrom
Open
feature: IntelliJ plugin supports projects inside WSL2 (wsl/linux jdk). Fixes #899#1624KaiFieger wants to merge 1 commit intopalantir:developfrom
KaiFieger wants to merge 1 commit intopalantir:developfrom
Conversation
Member
|
Thanks for your interest in palantir/palantir-java-format, @KaiFieger! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
✅ Successfully generated changelog entry!Entry generated via PR titleTo modify this entry, edit PR title using proper format. 📋Changelog Preview✨ Features
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Windows IntelliJ supports pure WSL2 projects (Java JDK also inside WSL2)
The IntelliJ plugin currently does not work for these projects. It tries to execute the formatter with the project's Java JDK, but fails to find it. #899
After this PR
The plugin now supports WSL2 projects. It finds the JDK and uses it to launch the formatter inside of WSL2.
Possible downsides?
Any other scenarios should work the same as before.
Other options
Running the formatter in WSL2 is slower than native Windows (as expected). So users might feel a noticeable difference between their Windows and WSL2 projects.
Introducing an extra setting where users can select a separate jdk for the plugin to use might be an option.