Add the ability to ignore suppressions in SuppressibleTreePathScanner#200
Merged
bulldozer-bot[bot] merged 2 commits intodevelopfrom Oct 16, 2025
Merged
Add the ability to ignore suppressions in SuppressibleTreePathScanner#200bulldozer-bot[bot] merged 2 commits intodevelopfrom
SuppressibleTreePathScanner#200bulldozer-bot[bot] merged 2 commits intodevelopfrom
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview✨ Features
|
CRogers
reviewed
Oct 16, 2025
...one/src/main/java/com/palantir/gradle/suppressibleerrorprone/modes/common/CommonOptions.java
Outdated
Show resolved
Hide resolved
CRogers
reviewed
Oct 16, 2025
.../main/java/com/palantir/gradle/suppressibleerrorprone/modes/common/ModifyCheckApiOption.java
Outdated
Show resolved
Hide resolved
CRogers
reviewed
Oct 16, 2025
.../main/java/com/palantir/gradle/suppressibleerrorprone/modes/common/ModifyCheckApiOption.java
Outdated
Show resolved
Hide resolved
CRogers
reviewed
Oct 16, 2025
...alantir/gradle/suppressibleerrorprone/transform/SuppressibleTreePathScannerClassVisitor.java
Show resolved
Hide resolved
CRogers
reviewed
Oct 16, 2025
...main/java/com/palantir/gradle/suppressibleerrorprone/transform/ModifyErrorProneCheckApi.java
Outdated
Show resolved
Hide resolved
CRogers
approved these changes
Oct 16, 2025
|
Released 2.21.0 |
This was referenced Oct 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
We are working on
-PerrorProneRemoveUnused, a mode which removes all unused suppressions. This mode requires us to turn on the ignore suppressions option in error-prone, or else we can't descend into suppressed trees to chec.Error-prone's
SuppressibleTreePathScannerdoesn't respect this flag. This is not expected behavior, asErrorProneScannerrespects the flag. We've opened google/error-prone#5255, but I think it will take some time to be merged. In the mean time, let's add the option to insert some bytecode so theSuppressibleTreePathScannerrespects this flag when we need it to.After this PR
==COMMIT_MSG==
Add the ability to ignore suppressions in
SuppressibleTreePathScanner==COMMIT_MSG==
Possible downsides?