Open
Conversation
Author
|
Adding |
Member
|
Would it be possible to document where this patch comes from for future code archaeologists? Perhaps a PATCHES-butler.txt file? |
Member
|
@byrond sorry to even ping you on this! We aren't starting new projects with Butler these days, so I'm not worried about getting this PR wrapped up -- in fact I probably won't follow up on it at all! |
Author
|
No worries, @becw! The patch is from a commit to a repository that referenced that Singularity GS issue. jobiqo/recruiter_epiq_deps@6bf87a1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating gulp-sass on #100, several
DEPRECATEDwarnings are issued when building the styleguide. Singularity is EOL and no longer maintained, so it must be patched (see https://github.com/at-import/Singularity/releases/tag/v1.8.0).This PR updates Butler using the method in at-import/Singularity#245 (comment)
After updating or creating the styleguide for a project, run:
yarn patch-packageThis will apply the patch to your instance (it isn't automatically run when adding Butler). The installation instructions in Butler's readme will need to be updated accordingly. However, they are currently written for using
npm. The patch requires Yarn, because the path to Singularity doesn't includenode_modules/butler/node_modules.This PR also includes a limited update to
npm-shrinkwrap.jsonthat only changes the URL of the 'asap' package, removing the internal Uber path. It replaces #90, since there were concerns there about regressions.