Conversation
| /* Link (a:) */ | ||
| $link-color: $gray-dark; | ||
| $link-hover: $secondary; | ||
| $link-hover: $gray-dark; |
There was a problem hiding this comment.
@aCyborg what was the logic behind changing the default link hover color?
There was a problem hiding this comment.
@MichellanneLi I stripped out anything 'project' related, and primary colors were project specific. You'll notice that I've changed everything to the grayscale palette.
| @@ -0,0 +1,8 @@ | |||
| # npm removes this file from butler on install if we name it .gitignore, but | |||
| # it's a necessary part of the Spress template! | |||
There was a problem hiding this comment.
@aCyborg does that mean you think we should rename it?
There was a problem hiding this comment.
I believe this is some comments lauren wrote. it is only marked as 'new' since it is in a new directory. this gitignore should match the git ignore in the other spress template.
| * @see https://drupal.org/node/1446420 | ||
| * @see http://www.adequatelygood.com/2010/3/JavaScript-Module-Pattern-In-Depth | ||
| * | ||
| * @copyright Copyright 2016 Palantir.net |
There was a problem hiding this comment.
@aCyborg copyright needs to be updated. Might as well make everything "2018" since we're so close.
There was a problem hiding this comment.
if we want to update to 2018, we will have to update here as well as sass partials.
| section: element | ||
|
|
||
| title: Buttons | ||
| description: Create basic button styles for the site. This includes only the button element and the inputs for submit and reset. |
There was a problem hiding this comment.
@aCyborg I'd drop "Create" so that this doesn't sound like instructions for the client. Also drop "only," since it implies that there are other button-like things we are leaving out.
|
|
||
| <div class="form-row"> | ||
| <div class="input-wrapper--half"> | ||
| <label for="name">Email Input:</label> |
| </div> | ||
|
|
||
| <div class="input-wrapper--half"> | ||
| <label for="name">URL Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
|
|
||
| <div class="form-row"> | ||
| <div class="input-wrapper--half"> | ||
| <label for="name">Telephone Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
| </div> | ||
|
|
||
| <div class="input-wrapper--half"> | ||
| <label for="name">Number Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
|
|
||
| <div class="form-row"> | ||
| <div class="input-wrapper--half"> | ||
| <label for="name">Range Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
| </div> | ||
|
|
||
| <div class="input-wrapper--half"> | ||
| <label for="name">Date Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
|
|
||
| <div class="form-row"> | ||
| <div class="input-wrapper--half"> | ||
| <label for="name">Month Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
| </div> | ||
|
|
||
| <div class="input-wrapper--half"> | ||
| <label for="name">Week Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
|
|
||
| <div class="form-row"> | ||
| <div class="input-wrapper--half"> | ||
| <label for="name">Time Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
| </div> | ||
|
|
||
| <div class="input-wrapper--half"> | ||
| <label for="name">Datetime Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
|
|
||
| <div class="form-row"> | ||
| <div class="input-wrapper--half"> | ||
| <label for="name">Datetime Local Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
| </div> | ||
|
|
||
| <div class="input-wrapper--half"> | ||
| <label for="name">Color Input:</label> |
There was a problem hiding this comment.
label attribute is incorrect.
|
|
||
| <div class="form-row"> | ||
| <div class="input-wrapper"> | ||
| <label for="name">Text Input:</label> |
There was a problem hiding this comment.
@aCyborg I think it would be helpful to also include text input with the following attributes:
- read only
- required
- disabled
| <main> | ||
| <h2>Living Styleguide</h2> | ||
| <p>This website acts as a living reference for the styles that exist on the live website for {{ site.title }}. The two sites share some design elements and components and deviate when necessary.</p> | ||
|
|
There was a problem hiding this comment.
@aCyborg I find the second sentence in this description to be confusing: "The two sites. . . " It negates the idea that the client's website is built off of the style guide. Maybe just nix it?
There was a problem hiding this comment.
oh this is probably leftover from mount sinai, they had two sites.
| <h2>Living Styleguide</h2> | ||
| <p>This website acts as a living reference for the styles that exist on the live website for {{ site.title }}. The two sites share some design elements and components and deviate when necessary.</p> | ||
|
|
||
| <p>The styleguide is broken up into three sections. 'Design Elements' which are the very basic building blocks for the website; 'Components' which combine design elements into working pieces of code that serves a defined purpose; and 'Page Templates' which combine the elements and components into page templates that are used to display the content at destination URLs.</p> |
There was a problem hiding this comment.
Add a colon after "sections"
| <ul> | ||
| {% for template in site.templates %} | ||
| {% if template.type == 'landing' %} | ||
| <li><a href="{{ site.url }}{{ template.url }}" target="_blank">{{ template.title }}</a></li> |
There was a problem hiding this comment.
@aCyborg I'm wondering if we should be using the target="_blank" attribute, given that it's not great for accessibility. Or, perhaps we could continue to use it, but add an icon and/or hidden text to alert the user that a new window will be opened?
There was a problem hiding this comment.
I'm open to removing it or modifying it, feel free to make many PRs against this branch!
|
@aCyborg I finished reviewing all the code today. It took a long time, so I'll spin up butler tomorrow and take a look at it in the browser. |
|
@aCyborg I noticed that when I install butler from this branch, my local src folder reflects the content in the "STYLEGUIDE_TEMPLATE_SPRESS" folder and not the "STLYEGUIDE_SPRESS_UPDATE" folder. To resolve this, I've just been copying over the "STLYEGUIDE_SPRESS_UPDATE" folder, but wanted to document this issue. |
2 participants
Creates a new spress template based on work done on Argonne and on Mount Sinai.
Remaining work: