add PROTECT/UNPROTECT pairs for rchk#235
Merged
paleolimbot merged 1 commit intopaleolimbot:masterfrom Dec 21, 2025
Merged
Conversation
paleolimbot
approved these changes
Dec 21, 2025
Owner
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
Thank you!
I wonder if Rf_getAttrib() being considered an allocating function is new or whether it just started allocating for some reason. (This code hasn't changed in a while)
Contributor
Author
|
It seems so; R core is hardening access to attributes to have better guarantees of their consistency, see here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the problems reported here.