Omit top-level sg from VPC launch-options#11
Open
mccraigmccraig wants to merge 1 commit intopallet:developfrom
Open
Omit top-level sg from VPC launch-options#11mccraigmccraig wants to merge 1 commit intopallet:developfrom
mccraigmccraig wants to merge 1 commit intopallet:developfrom
Conversation
If an instance is placed in a VPC by providing :network-interfaces options then the top-level security group name munged from the pallet group name must not be used, or the AWS API will throw an Exception. This commit omits the :security-groups key from launch-options when the node-spec has a [:provider :pallet-ec2 :network-interfaces] key.
Author
|
hmm. this may be ill-conceived... the sg-id should ideally be gotten from the group-spec rather than the node-spec... i will consider further tomorrow |
Author
|
ok,
so, despite specifying the security-group-id on the node-spec possibly requiring that a different version of the node-spec (with a different security-group-id) will be required for each group, this seems to be the way it is currently done in which context, this PR seems reasonable |
Author
|
on further investigation, it seems that pallet-aws uses a tag on instances to keep track of the pallet group that an instance belongs to, so there's no need to specialise node-specs with different security groups, so this PR seems even more reasonable (apologies for my thrashing about : i'm a pallet n00b) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an instance is placed in a VPC by providing :network-interfaces
options then the top-level security group name munged from the
pallet group name must not be used, or the AWS API will throw an
Exception.
This commit omits the :security-groups key from launch-options
when the node-spec has a [:provider :pallet-ec2 :network-interfaces]
key.
The problem is described in more detail with stacktraces here :
https://groups.google.com/forum/#!topic/pallet-clj/sWu-4IanCW0