insert alert messages on create/edit/upload forms #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElLorans
added a commit
that referenced
this pull request
Jan 1, 2026
Contributor
|
This had to be reverted with #2737 since the err msg was getting flashed even when accessing the edit form for the first time. We need the tests to check also that the msg is not flashed when it shouldn't. |
Contributor
Author
|
ok i will fix it with adding extra tests to make sure it is not showing on GET request |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows an alert message if a record failed to create/edit/upload
Why this PR
Without this PR, the enduser might get confused after submitting the create/edit/upload form if the proccess is failed. Yes the error desctiption will be presented under each invalid form field, but still the enduser needs a flash message to alert him with the failure of the proccess so that he can investigate the page looking for the invalid field.