Skip to content

fix inaccessible_callback when it returns None #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElLorans merged 1 commit into from
Feb 13, 2026
Merged

fix inaccessible_callback when it returns None #2793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flask_admin/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,9 @@ def _handle_view(self, name: str, **kwargs: dict[str, t.Any]) -> t.Any:
:param kwargs:
View function arguments
"""
# abort(403)
if not self.is_accessible():
return self.inaccessible_callback(name, **kwargs)
return self.inaccessible_callback(name, **kwargs) or abort(403)

def _run_view(
self, fn: t.Callable[..., t.Any], *args: t.Any, **kwargs: t.Any
Expand Down
7 changes: 7 additions & 0 deletions flask_admin/tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,13 @@ def test_inaccessible_callback(app, admin):
rv = client.get("/admin/mockview/")
assert rv.status_code == 418

# if inaccessible_callback returns None
view.allow_access = False
view.inaccessible_callback = lambda *args, **kwargs: None # type: ignore[method-assign]

rv = client.get("/admin/mockview/")
assert rv.status_code == 403


def get_visibility(app, admin):
view = MockView(name="TestMenuItem")
Expand Down