Fixed vulnerability by explicitly passing an SSL context to enable server certificate verification#241
Open
nitram2342 wants to merge 2 commits intopallets-eco:mainfrom
Open
Fixed vulnerability by explicitly passing an SSL context to enable server certificate verification#241nitram2342 wants to merge 2 commits intopallets-eco:mainfrom
nitram2342 wants to merge 2 commits intopallets-eco:mainfrom
Conversation
Author
|
Since the pull request, quite some time passed and the pull request fixes a security problem. Are there any thoughts on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to propose this change, which basically consists of explicitly passing an SSL/TLS context. Otherwise, the SMTP client does not verify the server cert. The background is explained in https://www.pentagrid.ch/en/blog/python-mail-libraries-certificate-verification/