Conversation
Most changes were to simply add a default <title> Validation did find some other bugs: - Other duplicate HTML ids in some of the more complex multi-form templates - Error in one-time-code input type Changed some titles to get more consistent around case Added (manual) test to use W3C validator to check templates. We can't do this all the time since we get rate-limited. Currently TWO_FACTOR_VERIFY_CODE template is failing due to some label close #1064
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 39 39
Lines 4917 4917
=======================================
Hits 4840 4840
Misses 77 77 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most changes were to simply add a default <title>
Validation did find some other bugs:
Changed some titles to get more consistent around case
Added (manual) test to use W3C validator to check templates. We can't do this all the time since we get rate-limited.
Currently TWO_FACTOR_VERIFY_CODE template is failing due to some label
close #1064
@ademaro please review.. Thanks!