Potential fix for code scanning alert no. 19: Workflow does not contain permissions#1161
Merged
Potential fix for code scanning alert no. 19: Workflow does not contain permissions#1161
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Chris Wagner <jwag.wagner@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 40 40
Lines 5008 5008
=======================================
Hits 4934 4934
Misses 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThiefMaster
reviewed
Dec 27, 2025
Comment on lines
+9
to
+10
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
You can probably put this on the top level as a default for all jobs that don't specify something else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/pallets-eco/flask-security/security/code-scanning/19
In general, the fix is to explicitly define a minimal
permissionsblock for thebuildjob so that theGITHUB_TOKENis restricted to only what the job actually needs. For this job, it only needs to read the repository contents (foractions/checkout) and does not push commits, create releases, or modify issues, socontents: readis sufficient.Concretely, in
.github/workflows/publish.yaml, underjobs: build:, add apermissions:section withcontents: read. Place it alongsideruns-onandoutputs, not understeps. No other functionality needs to change, and no additional imports or dependencies are required. The other jobs (create-releaseandpublish-pypi) already have appropriately scoped permissions and should remain as they are.Suggested fixes powered by Copilot Autofix. Review carefully before merging.