Fix compatibility with pyright 1.1.394#2855
Merged
davidism merged 1 commit intopallets:stablefrom May 11, 2025
Merged
Conversation
adamtheturtle
force-pushed
the
bump-typing-requirements
branch
3 times, most recently
from
366e519 to
147225b
Compare
davidism
force-pushed
the
bump-typing-requirements
branch
from
147225b to
6fec395
Compare
Member
|
I had ended up fixing this while updating the dependencies. But you did have a better solution for the ctypes issue, so I'm merging that part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use
pyright --verifytypeson a project which depends onclick. I do not use--ignoreexternal.With
pyright==1.1.394I started seeing errors.These are related to how
pyrightconsiders instance variables without explicit types to be ambiguous. See https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#ambiguous-types.Click's CI also fails with the latest
pyright, so I ranpip-compileto re-generate the typing requirements, and fixed the issues which came up.Fixes #2856