Skip to content

Release version 8.3.1#3109

Merged
davidism merged 1 commit intopallets:stablefrom
Rowlando13:release-8.3.1
Nov 15, 2025
Merged

Release version 8.3.1#3109
davidism merged 1 commit intopallets:stablefrom
Rowlando13:release-8.3.1

Conversation

@Rowlando13
Copy link
Collaborator

@Rowlando13 Rowlando13 commented Oct 15, 2025

No description provided.

@Rowlando13 Rowlando13 added this to the 8.3.1 milestone Oct 15, 2025
@Rowlando13 Rowlando13 requested a review from davidism October 15, 2025 04:38
@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Oct 26, 2025

@davidism can you please review this.

@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Oct 26, 2025 •
edited
Loading

Actually maybe not. This release causes failures in Flasks test suite.

@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Oct 26, 2025

@kdeldycke can you look at this issue in Flasks test suite. If we know that 8.3.1 is going to have something major broken, then better to hold the release and fix it.

@dotlambda
Copy link

dotlambda commented Oct 26, 2025

This release causes failures in Flasks test suite. See pallets/flask#5836.

I can confirm that Flask's tests don't fail with click 8.3.0.

@fabianhjr fabianhjr mentioned this pull request Oct 29, 2025
Merged
13 tasks
@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Nov 10, 2025

Minimal example of pallets/flask#5836. is #3136

@thesamesam

This comment was marked as off-topic.

Sign in to view
@davidism

This comment was marked as off-topic.

Sign in to view
@eli-schwartz

This comment was marked as off-topic.

Sign in to view
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Nov 10, 2025
@thesamesam
dev-python/click: destabilize & mask 8.3.0
9d31686 
8.3.1 is a quasi-release and 8.3.0 has regressions, so destabilise
and mask 8.3.0 too (8.3.1 was done in af95459).

Bug: https://bugs.gentoo.org/964910
Bug: pallets/click#3087
Bug: pallets/click#3109
Signed-off-by: Sam James <sam@gentoo.org>
@Rowlando13 Rowlando13 marked this pull request as draft November 11, 2025 05:30
@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Nov 11, 2025

This is on hold until #3136 is patched.

@Rowlando13 Rowlando13 mentioned this pull request Nov 11, 2025
Closed
17 tasks
@kdeldycke
Copy link
Collaborator

kdeldycke commented Nov 11, 2025

I just proposed a fix to the last remaining issue at: #3137

@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Nov 15, 2025

I ran flask's test suite with click's latest stable branch and they all pass, so everything looks good.

@Rowlando13 Rowlando13 marked this pull request as ready for review November 15, 2025 08:10
@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Nov 15, 2025

@davidism Can you please review and approve the upload job.

davidism
davidism reviewed Nov 15, 2025
View reviewed changes
@Rowlando13
Copy link
Collaborator Author

Rowlando13 commented Nov 15, 2025

@davidism fixed.

@davidism
Copy link
Member

davidism commented Nov 15, 2025

Let's rebase to squash these commits, then re-tag.

@pallets pallets deleted a comment from dotlambda Nov 15, 2025
@pallets pallets locked as off-topic and limited conversation to collaborators Nov 15, 2025
@davidism davidism merged commit edbbe6e into pallets:stable Nov 15, 2025
15 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidism davidism davidism left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.3.1

Development

Successfully merging this pull request may close these issues.

6 participants

@Rowlando13 @dotlambda @thesamesam @davidism @eli-schwartz @kdeldycke