Add type hints to tutorial and Javascript examples #5821
Closed
+26
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaCry
commented
Sep 26, 2025
SebaCry
commented
- Add return type annotations and parameter types
- Import necessary typing modules (Optional, Union, Flask, Response)
- Improve code readability and IDE support for examples
- All existing tests continue to pass
- Add return type annotations and parameter types - Import necessary typing modules (Optional, Union, Flask, Response) - Improve code readability and IDE support for examples - All existing tests continue to pass
|
LGTM, follows other areas of the source in style, thanks for adding the type hints! |
Author
|
Thanks!! I'll do it |
|
@davidism This PR got closed but I don't see it merged back into main. I'm still learning so was just wondering what that means. The code changes have been deemed unnecessary or they will be merged back into main at som point? |
Member
|
IMHO the changes are not particularly useful and just make otherwise simple examples harder to understand, especially for beginners. Having type hints on view functions in an application do not add any rael benefit, unlike type hints on library code, utils, etc. |
Author
|
Well said, an opinion hahaha |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.