Improve exception handler in wsgi_app method #5868
Closed
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace bare except clause with explicit BaseException handler for better code clarity and to avoid potential issues with sys.exc_info(). The previous code used a bare except: clause with sys.exc_info()[1] which is discouraged in Python. This change makes the exception handling more explicit by catching BaseException directly, which includes KeyboardInterrupt and SystemExit that should not be handled by the normal exception handler. Changes: - Replace bare except: with except BaseException as e: - Add explanatory comment about BaseException handling - Remove noqa: B001 comment as it's no longer needed All existing tests pass successfully.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the bare except clause with an explicit BaseException
handler for better code clarity and to avoid potential issues with
sys.exc_info().
The previous code used a bare except: clause with sys.exc_info()[1] which
is discouraged in Python. This change makes the exception handling more
explicit by catching BaseException directly, which includes KeyboardInterrupt
and SystemExit that should not be handled by the normal exception handler.
All existing tests pass successfully.