Track column numbers (colno) in AST nodes#2134
Closed
daniel7an wants to merge 1 commit intopallets:mainfrom
Closed
Track column numbers (colno) in AST nodes#2134daniel7an wants to merge 1 commit intopallets:mainfrom
daniel7an wants to merge 1 commit intopallets:mainfrom
Conversation
Add column number tracking to AST nodes, complementing the existing lineno attribute. This enables more precise source location reporting for static analysis tools working with Jinja templates. Changes: - Add colno field to Token namedtuple (default 0, backward compatible) - Track column position in tokeniter based on source position - Add colno attribute to Node base class - Add Node.set_colno() method mirroring set_lineno() - Propagate colno from tokens to nodes throughout the parser - Update ext.py token unpacking for compatibility - Add comprehensive tests for column number tracking Closes #2133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add column number (colno) tracking to AST nodes, complementing the existing lineno attribute. This enables more precise source location reporting for static analysis tools.
Closes #2133
Changes:
Example:
Backward compatible: Token.colno defaults to 0, Node.colno defaults to None. All 911 existing tests pass. Added 12 new tests.