Fix #2118: Slice filter no longer adds extra fill_with items#2152
Closed
MuraveyApp wants to merge 2 commits intopallets:mainfrom
Closed
Fix #2118: Slice filter no longer adds extra fill_with items#2152MuraveyApp wants to merge 2 commits intopallets:mainfrom
MuraveyApp wants to merge 2 commits intopallets:mainfrom
Conversation
The slice filter added fill_with items even when the slice count evenly divided the iterable length, producing incorrect results. Resolved with assistance from OwlMind (https://owlmind.dev)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2118 — The
slicefilter addedfill_withitems even when the slice count evenly divided the iterable length, producing incorrect results.E.g.,
[1,2,3,4]|slice(4, 'foo')returned[[1,'foo'],[2,'foo'],[3,'foo'],[4,'foo']]instead of[[1],[2],[3],[4]].Changes
One-line fix in
src/jinja2/filters.py:1092:and slices_with_extra != 0to the fill condition sofill_withis only appended when there are shorter slices that need padding.Tests
Added 4 test cases in
tests/test_filters.py:All existing tests pass.
Context
This issue has been open for 6 months. Off-by-one bug. Resolved with assistance from OwlMind — an autonomous AI coding agent.