Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/jinja2/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,11 @@ def sync_do_slice(
end = offset + (slice_number + 1) * items_per_slice
tmp = seq[start:end]

if fill_with is not None and slice_number >= slices_with_extra:
if (
fill_with is not None
and slices_with_extra > 0
and slice_number >= slices_with_extra
):
tmp.append(fill_with)

yield tmp
Expand Down
6 changes: 6 additions & 0 deletions tests/test_async_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ def test_slice(env_async, items):
)


@mark_dualiter("items", lambda: [1, 2, 3, 4])
def test_slice_fill_with_even_division(env_async, items):
tmpl = env_async.from_string("{{ items()|slice(4, 'X')|list }}")
assert tmpl.render(items=items) == "[[1], [2], [3], [4]]"


def test_unique_with_async_gen(env_async):
items = ["a", "b", "c", "c", "a", "d", "z"]
tmpl = env_async.from_string("{{ items|reject('==', 'z')|unique|list }}")
Expand Down
5 changes: 5 additions & 0 deletions tests/test_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ def test_slice(self, env):
"[[0, 1, 2, 3], [4, 5, 6, 'X'], [7, 8, 9, 'X']]"
)

def test_slice_fill_with_even_division(self, env):
tmpl = env.from_string("{{ foo|slice(4, 'X')|list }}")
out = tmpl.render(foo=[1, 2, 3, 4])
assert out == "[[1], [2], [3], [4]]"

def test_escape(self, env):
tmpl = env.from_string("""{{ '<">&'|escape }}""")
out = tmpl.render()
Expand Down
Loading