Open
Conversation
|
Just ran in to this issue and it was frustrating to get the 404 later on instead of the 403 from this call reported as a failure to authenticate. Had an old API key being used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple PR to just add a check for 403 when determining the apiVersion.
Currently a 403 results in a 0 being returned therefore if the server requires /api/v1 in the URL it will instead succeed in "passing" the version detection, and default to querying the server on /servers/localhost which ultimately results in a 404 which can be misleading when the simple fix was just the API key was wrong.