Conversation
Contributor
|
I know it's a draft but all these changes look good to me - will hold off on merging until you mark it as ready for review. |
lacraig2
reviewed
Sep 10, 2024
| if fname_ptr == self.ffi.NULL: | ||
| return None | ||
| return self.ffi.string(fname_ptr) | ||
| return self.ffi.string(fname_ptr).decode('utf8', 'ignore') |
Member
There was a problem hiding this comment.
As much as I like this change it will break all the code that uses this currently.
Also: in Linux I'd expect Latin-1.
Contributor
There was a problem hiding this comment.
+1 for Latin-1
PyPanda is versioned, are we not willing to make updates that break backwards compatibility with new versions? Or are you just suggesting we should update the in-tree uses of get_file_name to account for this change?
Member
Author
There was a problem hiding this comment.
We use utf-8 everywhere else in these interfaces, so maybe we should change those too if we're wanting to use Latin-1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor usability things