Skip to content

Conversation

cmp0xff
Copy link
Contributor

@cmp0xff cmp0xff commented Oct 3, 2025

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's the case that this makes reportUnusedVariable go away in strict, then you can delete the line in pyproject.toml that refers to it.

@cmp0xff cmp0xff changed the title refactor(ruff): comply to F841 refactor: comply to more ruff and pyright rules Oct 3, 2025
Copy link
Contributor Author

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are bigger now because two pyright rules are dropped

@cmp0xff cmp0xff requested a review from Dr-Irv October 3, 2025 15:07
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmp0xff

Seems like most of the changes are moving from 3.9 compliant code to 3.10. Did you use a tool to make that easier to do?

@Dr-Irv Dr-Irv merged commit 76fed11 into pandas-dev:main Oct 3, 2025
13 checks passed
@cmp0xff cmp0xff deleted the feature/cmp0xff/f841 branch October 3, 2025 19:03
@cmp0xff
Copy link
Contributor Author

cmp0xff commented Oct 3, 2025

Seems like most of the changes are moving from 3.9 compliant code to 3.10. Did you use a tool to make that easier to do?

Hi @Dr-Irv, I used regex to replace in one case, otherwise I used a brute-force approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df.drop signature does not capture all constraints
2 participants