Skip to content

GH1025 Typehint DataFrame.groupby.value_counts method #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

GH1025 Typehint DataFrame.groupby.value_counts method #1027

merged 2 commits into from
Nov 8, 2024

Conversation

loicdiridollou
Copy link
Member

Dr-Irv
Dr-Irv requested changes Nov 7, 2024
View reviewed changes
@loicdiridollou loicdiridollou requested a review from Dr-Irv November 8, 2024 01:24
Dr-Irv
Dr-Irv approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loicdiridollou

@Dr-Irv Dr-Irv merged commit 8d9be32 into pandas-dev:main Nov 8, 2024
10 checks passed
@loicdiridollou loicdiridollou deleted the gh1025_value_counts_groupby branch December 14, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groupby methods can return Series or DataFrame based on as_index variable
2 participants
@loicdiridollou @Dr-Irv