Skip to content

Conversation

loicdiridollou
Copy link
Member

),
pd.Series,
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test that doesn't include the as_index argument?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the issue wasn't there, I did a bad copy paste so it was the same test.
Now the tests are different. which includes the test case from the issue.
As well I have added a third case in both tests where we don't specify as_index as you mentioned above.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit 70ee340 into pandas-dev:main Nov 21, 2024
10 checks passed
@loicdiridollou loicdiridollou deleted the gh1045_groupby branch December 14, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to groupby.size() don't work for all possible groupby

2 participants