Fix Series.rename_axis and DataFrame.rename_axis typing

docs/setup.md

@@ -1,6 +1,7 @@
 ## Set Up Environment
 
 - Make sure you have `python >= 3.10` installed.
+- Make sure you have `hdf5` installed.
 - Install poetry: `pip install 'poetry>=1.8'`
 - Install the project dependencies: `poetry update`
 - Enter the virtual environment: `poetry shell`

pandas-stubs/core/frame.pyi

@@ -2070,40 +2070,44 @@ class DataFrame(NDFrame, OpsMixin):
         limit: int | None = ...,
         tolerance=...,
     ) -> DataFrame: ...
+    # Rename axis with `mapper`, `axis`, and `inplace=True`
     @overload
     def rename_axis(
         self,
-        mapper=...,
+        mapper: Scalar | ListLike | None = ...,
+        *,
         axis: Axis | None = ...,
         copy: _bool = ...,
-        *,
         inplace: Literal[True],
     ) -> None: ...
+    # Rename axis with `mapper`, `axis`, and `inplace=False`
     @overload
     def rename_axis(
         self,
-        mapper=...,
+        mapper: Scalar | ListLike | None = ...,
+        *,
         axis: Axis | None = ...,
         copy: _bool = ...,
-        *,
         inplace: Literal[False] = ...,
     ) -> DataFrame: ...
+    # Rename axis with `index` and/or `columns` and `inplace=True`
     @overload
     def rename_axis(
         self,
+        *,
         index: _str | Sequence[_str] | dict[_str | int, _str] | Callable | None = ...,
         columns: _str | Sequence[_str] | dict[_str | int, _str] | Callable | None = ...,
         copy: _bool = ...,
-        *,
         inplace: Literal[True],
     ) -> None: ...
+    # Rename axis with `index` and/or `columns` and `inplace=False`
     @overload
     def rename_axis(
         self,
+        *,
         index: _str | Sequence[_str] | dict[_str | int, _str] | Callable | None = ...,
         columns: _str | Sequence[_str] | dict[_str | int, _str] | Callable | None = ...,
         copy: _bool = ...,
-        *,
         inplace: Literal[False] = ...,
     ) -> DataFrame: ...
     def rfloordiv(

pandas-stubs/core/series.pyi

@@ -2076,24 +2076,41 @@ class Series(IndexOpsMixin[S1], NDFrame):
         numeric_only: _bool = ...,
         **kwargs,
     ) -> Scalar: ...
+    # Rename axis with `mapper`, `axis`, and `inplace=True`
     @overload
     def rename_axis(
         self,
-        mapper: Scalar | ListLike = ...,
-        index: Scalar | ListLike | Callable | dict | None = ...,
-        columns: Scalar | ListLike | Callable | dict | None = ...,
+        mapper: Scalar | ListLike | None = ...,
+        *,
         axis: AxisIndex | None = ...,
         copy: _bool = ...,
+        inplace: Literal[True],
+    ) -> None: ...
+    # Rename axis with `mapper`, `axis`, and `inplace=False`
+    @overload
+    def rename_axis(
+        self,
+        mapper: Scalar | ListLike | None = ...,
         *,
+        axis: AxisIndex | None = ...,
+        copy: _bool = ...,
+        inplace: Literal[False] = ...,
+    ) -> Self: ...
+    # Rename axis with `index` and `inplace=True`
+    @overload
+    def rename_axis(
+        self,
+        *,
+        index: Scalar | ListLike | Callable | dict | None = ...,
+        copy: _bool = ...,
         inplace: Literal[True],
     ) -> None: ...
+    # Rename axis with `index` and `inplace=False`
     @overload
     def rename_axis(
         self,
-        mapper: Scalar | ListLike = ...,
+        *,
         index: Scalar | ListLike | Callable | dict | None = ...,
-        columns: Scalar | ListLike | Callable | dict | None = ...,
-        axis: AxisIndex | None = ...,
         copy: _bool = ...,
         inplace: Literal[False] = ...,
     ) -> Self: ...

tests/test_frame.py

@@ -1955,6 +1955,32 @@ def test_types_rename() -> None:
     df.rename(columns=lambda s: s.upper())
 
 
+def test_types_rename_axis() -> None:
+    df = pd.DataFrame({"col_name": [1, 2, 3]})
+    df.index.name = "a"
+    df.columns.name = "b"
+
+    for _df in [
+        # Rename axes with `mapper` and `axis`
+        df.rename_axis("A"),
+        df.rename_axis(["A"]),
+        df.rename_axis(None),
+        df.rename_axis("B", axis=1),
+        df.rename_axis(["B"], axis=1),
+        df.rename_axis(None, axis=1),
+        # Rename axes with `index` and `columns`
+        df.rename_axis(index="A", columns="B"),
+        df.rename_axis(index=["A"], columns=["B"]),
+        df.rename_axis(index={"a": "A"}, columns={"b": "B"}),
+        df.rename_axis(
+            index=lambda name: name.upper(),
+            columns=lambda name: name.upper(),
+        ),
+        df.rename_axis(index=None, columns=None),
+    ]:
+        check(assert_type(_df, pd.DataFrame), pd.DataFrame)
+
+
 def test_types_eq() -> None:
     df1 = pd.DataFrame([[1, 2], [8, 9]], columns=["A", "B"])
     res1: pd.DataFrame = df1 == 1

tests/test_series.py

@@ -1121,7 +1121,22 @@ def test_types_eq() -> None:
 
 
 def test_types_rename_axis() -> None:
-    s: pd.Series = pd.Series([1, 2, 3]).rename_axis("A")
+    s = pd.Series([1, 2, 3])
+    s.index.name = "a"
+
+    for _s in [
+        # Rename index with `mapper`
+        s.rename_axis("A"),
+        s.rename_axis(["A"]),
+        s.rename_axis(None),
+        # Rename index with `index`
+        s.rename_axis(index="A"),
+        s.rename_axis(index=["A"]),
+        s.rename_axis(index={"a": "A"}),
+        s.rename_axis(index=lambda name: name.upper()),
+        s.rename_axis(index=None),
+    ]:
+        check(assert_type(_s, pd.Series[int]), pd.Series[int])
 
 
 def test_types_values() -> None: