Skip to content

GH1051 Drop astype tests for Mac arm for float128 and complex256 #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 27, 2024
Merged

GH1051 Drop astype tests for Mac arm for float128 and complex256 #1057

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9d141ae
GH1051 Drop astype tests for Mac arm for float128 and complex256
loicdiridollou Nov 26, 2024
1198fac
Fix
loicdiridollou Nov 26, 2024
b33f26e
Fix
loicdiridollou Nov 26, 2024
90cb79b
Test fix
loicdiridollou Nov 26, 2024
c3f2c7e
Move to macos-latest
loicdiridollou Nov 26, 2024
bde68dc
Update test.yml
loicdiridollou Nov 27, 2024
4c9b24a
GH1051 Lock in tables version to 3.10.1
loicdiridollou Nov 27, 2024
ce58155
GH1049 Deprecate Index and Grouper methods for 2.0 migration (#1050)
loicdiridollou Nov 25, 2024
733cdca
Change signature of StringMethods.rsplit to match pandas (#1056)
kroche98 Nov 25, 2024
0ae427f
GH1053 @ for DataFrame, eval in place for DataFrame, test migrations …
loicdiridollou Nov 26, 2024
2d7a4a4
GH1043 Update _typing.pyi: add "cross" option to JoinHow (#1044)
brzegorzTesco Nov 26, 2024
8a2d6b7
Version 2.2.3.241126
Dr-Irv Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
strategy:
fail-fast: false
matrix:
# Don't use macos-latest because it is arm64
os: [ubuntu-latest, windows-latest, macos-13]
# macos-latest is arm
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.10", "3.11", "3.12"]

name: OS ${{ matrix.os }} - Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ black = ">=23.3.0"
isort = ">=5.12.0"
openpyxl = ">=3.0.10"
# for tables, MacOS gives random CI failures on 3.9.2
tables = { version = "==3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
tables = { version = ">=3.9.2", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 3.10.1 is out, and it was what was used in the tests, so changing this from 3.9.2 to 3.10.1 is warranted.

lxml = ">=4.9.1"
pyreadstat = ">=1.2.0"
xlrd = ">=2.0.1"
Expand Down
18 changes: 18 additions & 0 deletions tests/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2429,6 +2429,15 @@ def test_astype_float(cast_arg: FloatDtypeArg, target_type: type) -> None:
s.astype(cast_arg)
pytest.skip("Windows does not support float128")

if (
platform.system() == "Darwin"
and platform.processor() == "arm"
and cast_arg in ("f16", "float128")
):
with pytest.raises(TypeError):
s.astype(cast_arg)
pytest.skip("MacOS arm does not support float128")

check(s.astype(cast_arg), pd.Series, target_type)

if TYPE_CHECKING:
Expand Down Expand Up @@ -2482,6 +2491,15 @@ def test_astype_complex(cast_arg: ComplexDtypeArg, target_type: type) -> None:
s.astype(cast_arg)
pytest.skip("Windows does not support complex256")

if (
platform.system() == "Darwin"
and platform.processor() == "arm"
and cast_arg in ("c32", "complex256")
):
with pytest.raises(TypeError):
s.astype(cast_arg)
pytest.skip("MacOS arm does not support complex256")

check(s.astype(cast_arg), pd.Series, target_type)

if TYPE_CHECKING:
Expand Down