Skip to content

GH1061 add calamine literal to ExcelFile engine #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2024
Merged

GH1061 add calamine literal to ExcelFile engine #1062

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79fea46
GH1061 add calamine literal to ExcelFile engine
sanzoghenzo Nov 30, 2024
9725c60
fix format
sanzoghenzo Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas-stubs/io/excel/_base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ class ExcelFile:
def __init__(
self,
io: FilePath | ReadBuffer[bytes] | bytes,
engine: Literal["xlrd", "openpyxl", "odf", "pyxlsb"] | None = ...,
engine: ExcelReadEngine | None = ...,
storage_options: StorageOptions = ...,
) -> None: ...
def __fspath__(self): ...
Expand Down
7 changes: 7 additions & 0 deletions tests/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,6 +1108,13 @@ def test_read_excel_dtypes():
dtypes = {"a": np.int64, "b": str, "c": np.float64}
check(assert_type(read_excel(path, dtype=dtypes), pd.DataFrame), pd.DataFrame)

def test_excel_reader():
with ensure_clean(".xlsx") as path:
check(assert_type(DF.to_excel(path), None), type(None))
with pd.ExcelFile(path, engine="calamine") as ef:
check(assert_type(ef, pd.ExcelFile), pd.ExcelFile)
check(assert_type(pd.read_excel(ef), pd.DataFrame), pd.DataFrame)


def test_excel_writer():
with ensure_clean(".xlsx") as path:
Expand Down
Loading