fixed pivot_table sort argument in pandas_stubs #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Dec 24, 2024
Dr-Irv
requested changes
Dec 24, 2024
tests/test_frame.py
Outdated
Comment on lines
1092
to
1097
| {'a': [1, 2], | ||
| 'b': [3, 4], | ||
| 'c': [5, 6], | ||
| 'd': [7, 8]} | ||
| ) | ||
| check(assert_type(df.pivot_table(values='a', index='b', columns='c', sort=True), |
There was a problem hiding this comment.
You need to use double quotes here.
Be sure to follow the instructions at https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md to set up your environment. And run tests as shown here: https://github.com/pandas-dev/pandas-stubs/blob/main/docs/tests.md
Dr-Irv
requested changes
Dec 24, 2024
Dr-Irv
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing parameter for the sort argument of the pandas.DataFrame.pivot_table method added and implemented tests