Skip to content

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 18, 2025

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

This came up in another PR (#1107 (comment))

It seems that the definitions have slightly drifted - OK to align them?

@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 18, 2025 18:15
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarcoGorelli There is more alignment to do - just need people to work on it!

@Dr-Irv Dr-Irv merged commit d14fb18 into pandas-dev:main Feb 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants