Skip to content

fix: #1008 columns in DataFrame.drop #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: #1008 columns in DataFrame.drop #1131

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e676401
fix: #1008 columns in DataFrame.drop
cmp0xff Feb 26, 2025
2697a01
fix(comment): #1008
cmp0xff Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pandas-stubs/core/generic.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ class NDFrame(indexing.IndexingMixin):
*,
axis: Axis = ...,
index: Hashable | Sequence[Hashable] | Index[Any] = ...,
columns: Hashable | Sequence[Hashable] | Index[Any],
columns: Hashable | Iterable[Hashable],
level: Level | None = ...,
inplace: Literal[True],
errors: IgnoreRaise = ...,
Expand All @@ -301,7 +301,7 @@ class NDFrame(indexing.IndexingMixin):
*,
axis: Axis = ...,
index: Hashable | Sequence[Hashable] | Index[Any],
columns: Hashable | Sequence[Hashable] | Index[Any] = ...,
columns: Hashable | Iterable[Hashable] = ...,
level: Level | None = ...,
inplace: Literal[True],
errors: IgnoreRaise = ...,
Expand All @@ -325,7 +325,7 @@ class NDFrame(indexing.IndexingMixin):
*,
axis: Axis = ...,
index: Hashable | Sequence[Hashable] | Index[Any] = ...,
columns: Hashable | Sequence[Hashable] | Index[Any],
columns: Hashable | Iterable[Hashable],
level: Level | None = ...,
inplace: Literal[False] = ...,
errors: IgnoreRaise = ...,
Expand All @@ -337,7 +337,7 @@ class NDFrame(indexing.IndexingMixin):
*,
axis: Axis = ...,
index: Hashable | Sequence[Hashable] | Index[Any],
columns: Hashable | Sequence[Hashable] | Index[Any] = ...,
columns: Hashable | Iterable[Hashable] = ...,
level: Level | None = ...,
inplace: Literal[False] = ...,
errors: IgnoreRaise = ...,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,9 @@ def test_types_drop() -> None:
df = pd.DataFrame(data={"col1": [1, 2], "col2": [3, 4]})
check(assert_type(df.drop("col1", axis=1), pd.DataFrame), pd.DataFrame)
check(assert_type(df.drop(columns=["col1"]), pd.DataFrame), pd.DataFrame)
check(assert_type(df.drop(columns=iter(["col1"])), pd.DataFrame), pd.DataFrame)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iter might be the easiest way to make an iterable

check(assert_type(df.drop([0]), pd.DataFrame), pd.DataFrame)
check(assert_type(df.drop(index=[0]), pd.DataFrame), pd.DataFrame)
check(assert_type(df.drop(columns=["col1"]), pd.DataFrame), pd.DataFrame)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed since it duplicates L346 above

check(assert_type(df.drop(index=1), pd.DataFrame), pd.DataFrame)
check(assert_type(df.drop(labels=0), pd.DataFrame), pd.DataFrame)
assert assert_type(df.drop([0, 0], inplace=True), None) is None
Expand Down