Skip to content

clean: Groupby deprecations #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

clean: Groupby deprecations #1143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 3 additions & 34 deletions pandas-stubs/core/groupby/generic.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ from collections.abc import (
Hashable,
Iterable,
Iterator,
Mapping,
Sequence,
)
from typing import (
Expand All @@ -29,14 +28,11 @@ from typing_extensions import (
TypeAlias,
)

from pandas._libs.lib import NoDefault
from pandas._libs.tslibs.timestamps import Timestamp
from pandas._typing import (
S1,
AggFuncTypeBase,
AggFuncTypeFrame,
ArrayLike,
Axis,
ByT,
CorrelationMethod,
Dtype,
Expand Down Expand Up @@ -113,26 +109,13 @@ class SeriesGroupBy(GroupBy[Series[S1]], Generic[S1, ByT]):
bins: int | Sequence[int] | None = ...,
dropna: bool = ...,
) -> Series[float]: ...
def fillna(
self,
value: (
Scalar | ArrayLike | Series | DataFrame | Mapping[Hashable, Scalar] | None
) = ...,
method: Literal["bfill", "ffill"] | None = ...,
axis: Axis | None | NoDefault = ...,
inplace: bool = ...,
limit: int | None = ...,
downcast: dict | None | NoDefault = ...,
) -> Series[S1] | None: ...
def take(
self,
indices: TakeIndexer,
axis: Axis | NoDefault = ...,
**kwargs,
) -> Series[S1]: ...
def skew(
self,
axis: Axis | NoDefault = ...,
skipna: bool = ...,
numeric_only: bool = ...,
**kwargs,
Expand All @@ -145,8 +128,8 @@ class SeriesGroupBy(GroupBy[Series[S1]], Generic[S1, ByT]):
def nsmallest(
self, n: int = ..., keep: Literal["first", "last", "all"] = ...
) -> Series[S1]: ...
def idxmin(self, axis: Axis | NoDefault = ..., skipna: bool = ...) -> Series: ...
def idxmax(self, axis: Axis | NoDefault = ..., skipna: bool = ...) -> Series: ...
def idxmin(self, skipna: bool = ...) -> Series: ...
def idxmax(self, skipna: bool = ...) -> Series: ...
def corr(
self,
other: Series,
Expand Down Expand Up @@ -242,13 +225,11 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
def nunique(self, dropna: bool = ...) -> DataFrame: ...
def idxmax(
self,
axis: Axis | None | NoDefault = ...,
skipna: bool = ...,
numeric_only: bool = ...,
) -> DataFrame: ...
def idxmin(
self,
axis: Axis | None | NoDefault = ...,
skipna: bool = ...,
numeric_only: bool = ...,
) -> DataFrame: ...
Expand Down Expand Up @@ -336,13 +317,10 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
ascending: bool = ...,
dropna: bool = ...,
) -> DataFrame: ...
def take(
self, indices: TakeIndexer, axis: Axis | None | NoDefault = ..., **kwargs
) -> DataFrame: ...
def take(self, indices: TakeIndexer, **kwargs) -> DataFrame: ...
@overload
def skew(
self,
axis: Axis | None | NoDefault = ...,
skipna: bool = ...,
numeric_only: bool = ...,
*,
Expand All @@ -352,7 +330,6 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
@overload
def skew(
self,
axis: Axis | None | NoDefault = ...,
skipna: bool = ...,
numeric_only: bool = ...,
*,
Expand Down Expand Up @@ -394,14 +371,6 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
) -> Series: ... # Series[Axes] but this is not allowed
@property
def dtypes(self) -> Series: ...
def corrwith(
self,
other: DataFrame | Series,
axis: Axis | NoDefault = ...,
drop: bool = ...,
method: CorrelationMethod = ...,
numeric_only: bool = ...,
) -> DataFrame: ...
def __getattr__(self, name: str) -> SeriesGroupBy[Any, ByT]: ...
# Overrides that provide more precise return types over the GroupBy class
@final # type: ignore[misc]
Expand Down