GH1089 Fix pandas nightly with new warnings on copy #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\pandas_nightly |
|
/pandas_nightly |
|
pandas_nightly passing, see https://github.com/pandas-dev/pandas-stubs/actions/runs/13749877460 |
2 tasks
Dr-Irv
requested changes
Mar 10, 2025
Dr-Irv
reviewed
Mar 11, 2025
There was a problem hiding this comment.
I tried this locally with the nightly test, and it failed. I had to upgrade matplotlib. I had to go from 3.8.4 -> 3.10.1 .
So I think pyproject.toml needs to have an updated matplotlib version for this to work. See https://matplotlib.org/stable/users/prev_whats_new/whats_new_3.10.0.html#boxplot-and-bxp-orientation-parameter
…-stubs into gh1089_fix_nightly
Dr-Irv
reviewed
Mar 12, 2025
|
Oh yes my bad I thought it was a dependency and not a dev dependency so
that would cause issues, I’ll update the PR and remove the split tests.
Thanks!
…On Wed, Mar 12, 2025 at 9:57 AM Irv Lustig ***@***.***> wrote:
***@***.**** commented on this pull request.
why not just bump up the version of matplotlib in pyproject.toml instead
of creating the tests for the version in test_plotting.py? We only need
it for development and CI.
Am I missing something here?
—
Reply to this email directly, view it on GitHub
<#1152 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMQNSQFAFWLV5W2GTHJS6XL2UA4MRAVCNFSM6AAAAABYUKLNDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZYGYYDCMRRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Concern is addressed, I have also limited the version of SQLAlchemy due to a typehint that is not up to date anymore. There is an issue to fix it but for now will just limit the version so that we can ship this to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value