type args and kwargs as Any in series.pyi #1170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1168
These are all cases where
kwargs/argsjust exist for compatibility with numpyExceptions are:
to_numpy, where the kwargs get passed to the extensionarray. Given that third parties can develop their own extensionarrays, I think this one really should beAny, we can't know what arguments third party EA authors will accept?pct_change: this could be more precise, have opened typekwargsinpct_changeaccording to params inshift#1169 about thatCloses #xxxx (Replace xxxx with the Github issue number)
Tests added: Please use
assert_type()to assert the type of any return value