Skip to content

Conversation

mike-flowers-airbnb
Copy link
Contributor

Updated based off documentation in config_init.py

Let me know if you'd like me to update the second test to also use assert_type on each value.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in tests. I don't have time right now to verify the changes to the types in Display - will do that in next review.

Copy link
Member

@loicdiridollou loicdiridollou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request as we are already touching the code here, otherwise looking in line with the pandas docs.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit ebe8d10 into pandas-dev:main Jun 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type checks for pd.options.display.* are not accurate

3 participants