Skip to content

GHXXX Clean up from stubtest #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2025
Merged

GHXXX Clean up from stubtest #1267

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
233bdcc
GHXXX Clean up from stubtest
loicdiridollou Jun 28, 2025
8f710a2
GHXXX PR feedback
loicdiridollou Jun 28, 2025
5e0a4f6
GHXXX PR feedback
loicdiridollou Jun 28, 2025
4bf557d
GHXXX Fix test
loicdiridollou Jun 29, 2025
466ff8c
GHXXX More cleanup
loicdiridollou Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pandas-stubs/core/groupby/groupby.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ from pandas.core.base import SelectionMixin
from pandas.core.frame import DataFrame
from pandas.core.groupby import (
generic,
ops,
)
from pandas.core.groupby.indexing import (
GroupByIndexingMixin,
Expand Down Expand Up @@ -357,7 +356,6 @@ class GroupByPlot(PlotAccessor, Generic[_GroupByT]):

class BaseGroupBy(SelectionMixin[NDFrameT], GroupByIndexingMixin):
axis: AxisInt
grouper: ops.BaseGrouper
keys: _KeysArgType | None
level: IndexLabel | None
group_keys: bool
Expand Down
4 changes: 0 additions & 4 deletions pandas-stubs/core/resample.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,12 @@ from typing import (
import numpy as np
from pandas import (
DataFrame,
Index,
Series,
Timedelta,
)
from pandas.core.groupby.generic import SeriesGroupBy
from pandas.core.groupby.groupby import BaseGroupBy
from pandas.core.groupby.grouper import Grouper
from pandas.core.groupby.ops import BinGrouper
from typing_extensions import (
Self,
TypeAlias,
Expand Down Expand Up @@ -59,8 +57,6 @@ _SeriesGroupByFuncArgs: TypeAlias = (
)

class Resampler(BaseGroupBy[NDFrameT]):
_grouper: BinGrouper
ax: Index
def __getattr__(self, attr: str) -> SeriesGroupBy: ...
@overload
def aggregate(
Expand Down
3 changes: 0 additions & 3 deletions tests/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import numpy as np
from pandas import (
DataFrame,
DatetimeIndex,
Index,
Series,
Timedelta,
Expand Down Expand Up @@ -74,7 +73,6 @@ def test_frame_groupby_resample() -> None:

# props
check(assert_type(GB_DF.resample("ME").obj, DataFrame), DataFrame)
check(assert_type(GB_DF.resample("ME").ax, Index), DatetimeIndex)

# agg funcs
with pytest_warns_bounded(
Expand Down Expand Up @@ -329,7 +327,6 @@ def test_series_groupby_resample() -> None:

# props
check(assert_type(GB_S.resample("ME").obj, "Series[float]"), Series, float)
check(assert_type(GB_S.resample("ME").ax, Index), DatetimeIndex)

# agg funcs
check(assert_type(GB_S.resample("ME").sum(), "Series[float]"), Series, float)
Expand Down
4 changes: 0 additions & 4 deletions tests/test_resampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
import pandas as pd
from pandas import (
DataFrame,
DatetimeIndex,
Index,
Series,
date_range,
)
Expand Down Expand Up @@ -38,7 +36,6 @@

def test_props() -> None:
check(assert_type(DF.resample("ME").obj, DataFrame), DataFrame)
check(assert_type(DF.resample("ME").ax, Index), DatetimeIndex)


def test_iter() -> None:
Expand Down Expand Up @@ -273,7 +270,6 @@ def f(val: Series) -> Series:

def test_props_series() -> None:
check(assert_type(S.resample("ME").obj, Series), Series)
check(assert_type(S.resample("ME").ax, Index), DatetimeIndex)


def test_iter_series() -> None:
Expand Down