refactor(series)!: 🕰️ drop TimestampSeries

pandas-stubs/core/series.pyi

@@ -1688,6 +1688,13 @@ class Series(IndexOpsMixin[S1], NDFrame):
         self: Series[_T_COMPLEX], other: np_ndarray_complex
     ) -> Series[complex]: ...
     @overload
+    def __add__(
+        self: Series[_str],
+        other: (
+            np_ndarray_bool | np_ndarray_anyint | np_ndarray_float | np_ndarray_complex
+        ),
+    ) -> Never: ...
+    @overload
     def __add__(
         self: Series[_str], other: _str | Sequence[_str] | np_ndarray_str | Series[_str]
     ) -> Series[_str]: ...
@@ -1951,6 +1958,13 @@ class Series(IndexOpsMixin[S1], NDFrame):
         self: Series[_T_COMPLEX], other: np_ndarray_complex
     ) -> Series[complex]: ...
     @overload
+    def __radd__(
+        self: Series[_str],
+        other: (
+            np_ndarray_bool | np_ndarray_anyint | np_ndarray_float | np_ndarray_complex
+        ),
+    ) -> Never: ...
+    @overload
     def __radd__(
         self: Series[_str], other: _str | Sequence[_str] | np_ndarray_str | Series[_str]
     ) -> Series[_str]: ...

tests/series/arithmetic/str/test_add.py

@@ -4,71 +4,119 @@
 import numpy as np
 from numpy import typing as npt  # noqa: F401
 import pandas as pd
-from typing_extensions import assert_type
+from typing_extensions import (
+    Never,
+    assert_type,
+)
 
-from tests import check
+from tests import (
+    TYPE_CHECKING_INVALID_USAGE,
+    check,
+)
 
 left = pd.Series(["1", "23", "456"])  # left operand
 
 
 def test_add_py_scalar() -> None:
-    """Testpd.Series[str]+ Python native str"""
+    """Testpd.Series[str]+ Python native 'scalar's"""
+    i = 4
     r0 = "right"
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        _0 = left + i  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
     check(assert_type(left + r0, "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        _1 = i + left  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
     check(assert_type(r0 + left, "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.add(i)  # type: ignore[call-overload] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.add(r0), "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.radd(i)  # type: ignore[call-overload] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.radd(r0), "pd.Series[str]"), pd.Series, str)
 
 
 def test_add_py_sequence() -> None:
     """Testpd.Series[str]+ Python native sequence"""
+    i = [3, 5, 8]
     r0 = ["a", "bc", "def"]
     r1 = tuple(r0)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        _0 = left + i  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
     check(assert_type(left + r0, "pd.Series[str]"), pd.Series, str)
     check(assert_type(left + r1, "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        _1 = i + left  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
     check(assert_type(r0 + left, "pd.Series[str]"), pd.Series, str)
     check(assert_type(r1 + left, "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.add(i)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.add(r0), "pd.Series[str]"), pd.Series, str)
     check(assert_type(left.add(r1), "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.radd(i)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.radd(r0), "pd.Series[str]"), pd.Series, str)
     check(assert_type(left.radd(r1), "pd.Series[str]"), pd.Series, str)
 
 
 def test_add_numpy_array() -> None:
     """Testpd.Series[str]+ numpy array"""
+    i = np.array([3, 5, 8], np.int64)
     r0 = np.array(["a", "bc", "def"], np.str_)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        assert_type(left + i, Never)
     check(assert_type(left + r0, "pd.Series[str]"), pd.Series, str)
 
-    # `numpy` typing gives `npt.NDArray[np.str_]` in the static type
+    # `numpy` typing gives `npt.NDArray[np.int64]` in the static type
     # checking, where our `__radd__` cannot override. At runtime, they return
     # `Series`s.
+    if TYPE_CHECKING_INVALID_USAGE:
+        assert_type(i + left, "npt.NDArray[np.int64]")
     if sys.version_info >= (3, 11):
+        # `numpy` typing gives `npt.NDArray[np.int64]` in the static type
+        # checking, where our `__radd__` cannot override. At runtime, they return
+        # `Series`s.
         check(assert_type(r0 + left, "npt.NDArray[np.str_]"), pd.Series, str)
     else:
+        # Python 3.10 uses NumPy 2.2.6, and it has for r0 ndarray[tuple[int,...], dtype[str_]]
+        # Python 3.11+ uses NumPy 2.3.2, and it has for r0 ndarray[tuple[Any,...,dtype[str_]]
+        # https://github.com/pandas-dev/pandas-stubs/pull/1274#discussion_r2291498975
         check(assert_type(r0 + left, Any), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.add(i)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.add(r0), "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.radd(i)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.radd(r0), "pd.Series[str]"), pd.Series, str)
 
 
 def test_add_pd_series() -> None:
     """Testpd.Series[str]+ pandas series"""
+    i = pd.Series([3, 5, 8])
     r0 = pd.Series(["a", "bc", "def"])
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        _0 = left + i  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
     check(assert_type(left + r0, "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        _1 = i + left  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
     check(assert_type(r0 + left, "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.add(i)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.add(r0), "pd.Series[str]"), pd.Series, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.radd(i)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
     check(assert_type(left.radd(r0), "pd.Series[str]"), pd.Series, str)

tests/series/test_series.py

@@ -1598,7 +1598,6 @@ def test_series_min_max_sub_axis() -> None:
     ss = s1 - s2
     sm = s1 * s2
     sd = s1 / s2
-    s1.__sub__(s2)
     check(assert_type(sa, pd.Series), pd.Series)
     check(assert_type(ss, pd.Series), pd.Series)
     check(assert_type(sm, pd.Series), pd.Series)