Skip to content

Improvements to arguments, types with stubtest #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 30, 2025
Merged

Improvements to arguments, types with stubtest #1294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c201ba
Improvements to arguments, types with stubtest
loicdiridollou Jul 27, 2025
63fc9fa
More changes for hist
loicdiridollou Jul 27, 2025
95e7f11
More improvements in the indexes
loicdiridollou Jul 27, 2025
2b64e3b
GH1294 PR feedback
loicdiridollou Jul 29, 2025
c07bab7
Merge branch 'main' of github.com:loicdiridollou/pandas-stubs into st…
loicdiridollou Jul 29, 2025
903f7e6
GH1294 Fix formatting and tests
loicdiridollou Jul 29, 2025
d38f988
Update pandas-stubs/core/frame.pyi
loicdiridollou Jul 30, 2025
49334e6
Merge branch 'main' into stubtest_improv_p2
loicdiridollou Jul 30, 2025
c8d2a5d
Fix order
loicdiridollou Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 42 additions & 52 deletions pandas-stubs/core/frame.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,21 @@ else:
@overload
def __getitem__(self, key: Hashable) -> Series: ...

AstypeArgExt: TypeAlias = (
AstypeArg
| Literal[
"number",
"datetime64",
"datetime",
"integer",
"timedelta",
"timedelta64",
"datetimetz",
"datetime64[ns]",
]
)
AstypeArgExtList: TypeAlias = AstypeArgExt | list[AstypeArgExt]

class DataFrame(NDFrame, OpsMixin, _GetItemHack):

__hash__: ClassVar[None] # type: ignore[assignment] # pyright: ignore[reportIncompatibleMethodOverride]
Expand Down Expand Up @@ -458,6 +473,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def to_gbq(
self,
destination_table: str,
*,
project_id: str | None = ...,
chunksize: int | None = ...,
reauth: bool = ...,
Expand Down Expand Up @@ -524,6 +540,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def to_parquet(
self,
path: FilePath | WriteBuffer[bytes],
*,
engine: ParquetEngine = ...,
compression: Literal["snappy", "gzip", "brotli", "lz4", "zstd"] | None = ...,
index: bool | None = ...,
Expand All @@ -535,6 +552,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def to_parquet(
self,
path: None = ...,
*,
engine: ParquetEngine = ...,
compression: Literal["snappy", "gzip", "brotli", "lz4", "zstd"] | None = ...,
index: bool | None = ...,
Expand Down Expand Up @@ -564,6 +582,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def to_html(
self,
buf: FilePath | WriteBuffer[str],
*,
columns: SequenceNotStr[Hashable] | Index | Series | None = ...,
col_space: ColspaceArgType | None = ...,
header: _bool = ...,
Expand Down Expand Up @@ -611,6 +630,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def to_html(
self,
buf: None = ...,
*,
columns: Sequence[Hashable] | None = ...,
col_space: ColspaceArgType | None = ...,
header: _bool = ...,
Expand Down Expand Up @@ -746,20 +766,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def eval(
self, expr: _str, *, inplace: Literal[False] = ..., **kwargs: Any
) -> Scalar | np.ndarray | Self | Series: ...
AstypeArgExt: TypeAlias = (
AstypeArg
| Literal[
"number",
"datetime64",
"datetime",
"integer",
"timedelta",
"timedelta64",
"datetimetz",
"datetime64[ns]",
]
)
AstypeArgExtList: TypeAlias = AstypeArgExt | list[AstypeArgExt]
@overload
def select_dtypes(
self, include: StrDtypeArg, exclude: AstypeArgExtList | None = ...
Expand Down Expand Up @@ -810,6 +816,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def reindex(
self,
labels: Axes | None = ...,
*,
index: Axes | None = ...,
columns: Axes | None = ...,
axis: Axis | None = ...,
Expand Down Expand Up @@ -1320,11 +1327,19 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
) -> Self: ...
@overload
def stack(
self, level: IndexLabel = ..., dropna: _bool = ..., sort: _bool = ...
self,
level: IndexLabel = ...,
dropna: _bool = ...,
sort: _bool = ...,
future_stack: Literal[False] = ...,
) -> Self | Series: ...
@overload
def stack(
self, level: IndexLabel = ..., future_stack: _bool = ...
self,
level: IndexLabel = ...,
dropna: _NoDefaultDoNotUse = ...,
sort: _NoDefaultDoNotUse = ...,
future_stack: Literal[True] = ...,
) -> Self | Series: ...
def explode(
self, column: Sequence[Hashable], ignore_index: _bool = ...
Expand Down Expand Up @@ -1360,9 +1375,9 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
**kwargs: Any,
) -> Self: ...
@overload
def aggregate( # pyright: ignore[reportOverlappingOverload]
def aggregate(
self,
func: AggFuncTypeBase | AggFuncTypeDictSeries,
func: AggFuncTypeBase | AggFuncTypeDictSeries = ...,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid. If you don't specify the value of func, an exception will be raised. Please revert.

axis: Axis = ...,
**kwargs: Any,
) -> Series: ...
Expand Down Expand Up @@ -1628,24 +1643,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def isin(self, values: Iterable | Series | DataFrame | dict) -> Self: ...
@property
def plot(self) -> PlotAccessor: ...
def hist(
self,
column: _str | list[_str] | None = ...,
by: _str | ListLike | None = ...,
grid: _bool = ...,
xlabelsize: float | str | None = ...,
xrot: float | None = ...,
ylabelsize: float | str | None = ...,
yrot: float | None = ...,
ax: PlotAxes | None = ...,
sharex: _bool = ...,
sharey: _bool = ...,
figsize: tuple[float, float] | None = ...,
layout: tuple[int, int] | None = ...,
bins: int | list = ...,
backend: _str | None = ...,
**kwargs: Any,
): ...
hist = ...
def boxplot(
self,
column: _str | list[_str] | None = ...,
Expand Down Expand Up @@ -1780,6 +1778,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
self,
start_time: _str | dt.time,
end_time: _str | dt.time,
inclusive: IntervalClosedType = ...,
axis: Axis | None = ...,
) -> Self: ...
@overload
Expand Down Expand Up @@ -1980,8 +1979,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
@final
def head(self, n: int = ...) -> Self: ...
@final
def infer_objects(self) -> Self: ...
# def info
def infer_objects(self, copy: _bool | None = ...) -> Self: ...
@overload
def interpolate(
self,
Expand Down Expand Up @@ -2077,15 +2075,13 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
self,
axis: Axis | None = ...,
skipna: _bool | None = ...,
level: None = ...,
numeric_only: _bool = ...,
**kwargs: Any,
) -> Series: ...
def min(
self,
axis: Axis | None = ...,
skipna: _bool | None = ...,
level: None = ...,
numeric_only: _bool = ...,
**kwargs: Any,
) -> Series: ...
Expand Down Expand Up @@ -2117,8 +2113,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
periods: int = ...,
fill_method: None = ...,
freq: DateOffset | dt.timedelta | _str | None = ...,
*,
axis: Axis = ...,
fill_value: Scalar | NAType | None = ...,
) -> Self: ...
def pop(self, item: _str) -> Series: ...
Expand All @@ -2133,7 +2127,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
self,
axis: Axis | None = ...,
skipna: _bool | None = ...,
level: None = ...,
numeric_only: _bool = ...,
min_count: int = ...,
**kwargs: Any,
Expand All @@ -2142,7 +2135,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
self,
axis: Axis | None = ...,
skipna: _bool = ...,
level: None = ...,
numeric_only: _bool = ...,
min_count: int = ...,
**kwargs: Any,
Expand Down Expand Up @@ -2305,18 +2297,16 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
self,
axis: Axis | None = ...,
skipna: _bool | None = ...,
level: None = ...,
ddof: int = ...,
numeric_only: _bool = ...,
**kwargs: Any,
) -> Series: ...
# Not actually positional, but used to handle removal of deprecated
def set_axis(self, labels, *, axis: Axis, copy: _bool = ...) -> Self: ...
def set_axis(self, labels, *, axis: Axis = ..., copy: _bool = ...) -> Self: ...
def skew(
self,
axis: Axis | None = ...,
skipna: _bool | None = ...,
level: None = ...,
numeric_only: _bool = ...,
**kwargs: Any,
) -> Series: ...
Expand All @@ -2326,7 +2316,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
self,
axis: Axis = ...,
skipna: _bool = ...,
level: None = ...,
ddof: int = ...,
numeric_only: _bool = ...,
**kwargs: Any,
Expand All @@ -2347,9 +2336,8 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
) -> Self: ...
def sum(
self,
axis: Axis | None = ...,
axis: Axis = ...,
skipna: _bool | None = ...,
level: None = ...,
numeric_only: _bool = ...,
min_count: int = ...,
**kwargs: Any,
Expand Down Expand Up @@ -2434,6 +2422,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def to_string(
self,
buf: FilePath | WriteBuffer[str],
*,
columns: SequenceNotStr[Hashable] | Index | Series | None = ...,
col_space: int | list[int] | dict[HashableT, int] | None = ...,
header: _bool | list[_str] | tuple[str, ...] = ...,
Expand All @@ -2457,6 +2446,8 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
def to_string(
self,
buf: None = ...,
*,
level: None = ...,
columns: Sequence[Hashable] | Index | Series | None = ...,
col_space: int | list[int] | dict[Hashable, int] | None = ...,
header: _bool | Sequence[_str] = ...,
Expand Down Expand Up @@ -2513,9 +2504,8 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
) -> Self: ...
def var(
self,
axis: Axis | None = ...,
axis: Axis = ...,
skipna: _bool | None = ...,
level: None = ...,
ddof: int = ...,
numeric_only: _bool = ...,
**kwargs: Any,
Expand Down
4 changes: 3 additions & 1 deletion pandas-stubs/core/generic.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ class NDFrame(indexing.IndexingMixin):
def to_markdown(
self,
buf: FilePath | WriteBuffer[str],
mode: FileWriteMode | None = ...,
*,
mode: FileWriteMode = ...,
index: _bool = ...,
storage_options: StorageOptions = ...,
**kwargs: Any,
Expand All @@ -152,6 +153,7 @@ class NDFrame(indexing.IndexingMixin):
def to_markdown(
self,
buf: None = ...,
*,
mode: FileWriteMode | None = ...,
index: _bool = ...,
storage_options: StorageOptions = ...,
Expand Down
Loading
Loading