Skip to content

fix: #1304 add PD_LTE_23 #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2025
Merged

fix: #1304 add PD_LTE_23 #1306

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
935b475
fix: #1304 PD_LTE_23 https://github.com/pandas-dev/pandas-stubs/issue…
cmp0xff Aug 3, 2025
0d9931a
fix: pandas nightly
cmp0xff Aug 4, 2025
a64f8e8
fix: mypy and naming
cmp0xff Aug 4, 2025
ce7498a
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1306#di…
cmp0xff Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions tests/series/arithmetic/test_truediv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from tests import (
PD_LTE_23,
WINDOWS,
check,
)

Expand Down Expand Up @@ -143,27 +144,37 @@ def test_truediv_pd_series() -> None:
check(assert_type(left.rdiv(c), pd.Series), pd.Series)


def test_path_div() -> None:
# GH 682
folder = Path.cwd()
def test_path_div(tmp_path: Path) -> None:
"""Test pd.Series of paths / path object.

folders = pd.Series([folder, folder])
check(assert_type(folders / Path("a.png"), pd.Series), pd.Series, Path)
Also GH 682."""
fpath = Path("a.png")
folders, fpaths = pd.Series([tmp_path, tmp_path]), pd.Series([fpath, fpath])

check(assert_type(folders / fpath, pd.Series), pd.Series, Path)
check(assert_type(folders.truediv(fpath), pd.Series), pd.Series, Path)
check(assert_type(folders.div(fpath), pd.Series), pd.Series, Path)

check(assert_type(tmp_path / fpaths, pd.Series), pd.Series, Path)
check(assert_type(fpaths.rtruediv(tmp_path), pd.Series), pd.Series, Path)
check(assert_type(fpaths.rdiv(tmp_path), pd.Series), pd.Series, Path)


def test_truediv_path() -> None:
def test_truediv_path(tmp_path: Path) -> None:
"""Test pd.Series / path object.

Also GH 682."""
left, p = pd.Series(["a.png", "b.gz", "c.txt"]), Path.cwd()
fnames = pd.Series(["a.png", "b.gz", "c.txt"])

check(assert_type(left / p, pd.Series), pd.Series, Path)
if PD_LTE_23:
# Bug in 3.0 https://github.com/pandas-dev/pandas/issues/61940
check(assert_type(p / left, pd.Series), pd.Series, Path)
check(assert_type(fnames / tmp_path, pd.Series), pd.Series, Path)
check(assert_type(tmp_path / fnames, pd.Series), pd.Series, Path)

check(assert_type(left.truediv(p), pd.Series), pd.Series, Path)
check(assert_type(left.div(p), pd.Series), pd.Series, Path)
if PD_LTE_23 or not WINDOWS:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The or not WINDOWS should not be necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ce7498a

# pyarrow.lib.ArrowInvalid: Could not convert WindowsPath('...') with type WindowsPath: did not recognize Python value type when inferring an Arrow data type
check(assert_type(fnames.truediv(tmp_path), pd.Series), pd.Series, Path)
check(assert_type(fnames.div(tmp_path), pd.Series), pd.Series, Path)

check(assert_type(left.rtruediv(p), pd.Series), pd.Series, Path)
check(assert_type(left.rdiv(p), pd.Series), pd.Series, Path)
check(assert_type(fnames.rtruediv(tmp_path), pd.Series), pd.Series, Path)
check(assert_type(fnames.rdiv(tmp_path), pd.Series), pd.Series, Path)
Loading