GH804 Fix property setter/getter for Index.names #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Aug 6, 2025
pandas-stubs/core/indexes/base.pyi
Outdated
Comment on lines
310
to
316
| def name(self) -> _str | None: ... | ||
| @name.setter | ||
| def name(self, value) -> None: ... | ||
| @property | ||
| def names(self) -> list[Hashable]: ... | ||
| def names(self) -> list[_str | None]: ... | ||
| @names.setter | ||
| def names(self, names: Sequence[Hashable]) -> None: ... | ||
| def names(self, names: SequenceNotStr[_str | None]) -> None: ... |
There was a problem hiding this comment.
All of these should use Hashable instead of _str
e.g., the following is valid:
df.index.names=[3]There was a problem hiding this comment.
Yes I realized this morning, all fixed with new test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value