Skip to content

feat(series): arithmetic truediv and sub #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 19, 2025
Merged

feat(series): arithmetic truediv and sub #1312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c9c46b0
feat: arithmetic sub
cmp0xff Aug 8, 2025
e3447cf
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1312#di…
cmp0xff Aug 8, 2025
672009e
feat(comment): https://github.com/pandas-dev/pandas-stubs/pull/1312#d…
cmp0xff Aug 11, 2025
5dab881
Merge branch 'main' into feature/cmp0xff/arithmetic-sub
cmp0xff Aug 14, 2025
1e9b11d
fix(comment): completeness https://github.com/pandas-dev/pandas-stubs…
cmp0xff Aug 14, 2025
c8e3ab2
fix: pd.Series[bool] - pd.Series[bool]
cmp0xff Aug 16, 2025
0a86897
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1312#di…
cmp0xff Aug 18, 2025
5c2a592
fix(comment): reduce Never https://github.com/pandas-dev/pandas-stubs…
cmp0xff Aug 18, 2025
0c7b5fe
fix: py310 and py311
cmp0xff Aug 18, 2025
62b1a2d
Merge branch 'main' into feature/cmp0xff/arithmetic-sub
cmp0xff Aug 18, 2025
f300b5d
fix(ty): ignore
cmp0xff Aug 18, 2025
2c5c14d
fix(ruff): revert changes
cmp0xff Aug 18, 2025
44d0be0
fix: comments
cmp0xff Aug 18, 2025
61de1a1
fix: comments
cmp0xff Aug 19, 2025
c4482de
fix: typing
cmp0xff Aug 19, 2025
1140a6d
fix: reduce ignore
cmp0xff Aug 19, 2025
d0bd63a
fix: reduce keyword argument
cmp0xff Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 27 additions & 23 deletions pandas-stubs/core/series.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2071,10 +2071,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
@overload
def __rxor__(self, other: int | np_ndarray_anyint | Series[int]) -> Series[int]: ...
@overload
def __sub__(
self, other: Timestamp | datetime | TimestampSeries
) -> TimedeltaSeries: ...
@overload
def __sub__(self: Series[Never], other: complex | _ListLike | Series) -> Series: ...
@overload
def __sub__(self, other: Series[Never]) -> Series: ... # type: ignore[overload-overlap]
Expand Down Expand Up @@ -2144,12 +2140,12 @@ class Series(IndexOpsMixin[S1], NDFrame):
@overload
def __sub__(
self: Series[Timestamp],
other: Timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64,
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
) -> TimestampSeries: ...
@overload
def __sub__(
self: Series[Timedelta],
other: Timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64,
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
) -> TimedeltaSeries: ...
@overload
def sub(
Expand Down Expand Up @@ -2239,6 +2235,22 @@ class Series(IndexOpsMixin[S1], NDFrame):
axis: int = 0,
) -> Series[complex]: ...
@overload
def sub(
self: Series[Timestamp],
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
level: Level | None = None,
fill_value: float | None = None,
axis: int = 0,
) -> Series[complex]: ...
@overload
def sub(
self: Series[Timedelta],
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
level: Level | None = None,
fill_value: float | None = None,
axis: int = 0,
) -> Series[complex]: ...
@overload
def sub(
self: Series[_T_COMPLEX],
other: (
Expand Down Expand Up @@ -2329,6 +2341,14 @@ class Series(IndexOpsMixin[S1], NDFrame):
axis: int = 0,
) -> Series: ...
@overload
def rsub(
self,
other: Series[Never],
level: Level | None = None,
fill_value: float | None = None,
axis: int = 0,
) -> Series: ...
@overload
def rsub(
self: Series[bool],
other: Just[int] | Sequence[Just[int]] | np_ndarray_anyint | Series[int],
Expand Down Expand Up @@ -2507,14 +2527,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
axis: AxisIndex = 0,
) -> Series: ...
@overload
def truediv(
self: Series[bool],
other: np_ndarray_bool,
level: Level | None = None,
fill_value: float | None = None,
axis: AxisIndex = 0,
) -> Never: ...
@overload
def truediv(
self: Series[bool],
other: (
Expand Down Expand Up @@ -2710,14 +2722,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
axis: AxisIndex = 0,
) -> Series: ...
@overload
def rtruediv(
self: Series[bool],
other: np_ndarray_bool,
level: Level | None = None,
fill_value: float | None = None,
axis: AxisIndex = 0,
) -> Never: ...
@overload
def rtruediv(
self: Series[bool],
other: (
Expand Down Expand Up @@ -3292,7 +3296,7 @@ class TimestampSeries(_SeriesSubclassBase[Timestamp, np.datetime64]):
self, other: Timestamp | datetime | TimestampSeries
) -> TimedeltaSeries: ...
@overload
def __sub__(
def __sub__( # pyright: ignore[reportIncompatibleMethodOverride]
self,
other: (
timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64 | BaseOffset
Expand Down
8 changes: 4 additions & 4 deletions tests/series/arithmetic/bool/test_truediv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def test_truediv_numpy_array() -> None:
)

if TYPE_CHECKING_INVALID_USAGE:
assert_type(left.truediv(b), Never)
left.truediv(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
check(assert_type(left.truediv(i), "pd.Series[float]"), pd.Series, np.floating)
check(assert_type(left.truediv(f), "pd.Series[float]"), pd.Series, np.floating)
check(
Expand All @@ -147,13 +147,13 @@ def test_truediv_numpy_array() -> None:
)

if TYPE_CHECKING_INVALID_USAGE:
assert_type(left.div(b), Never)
left.div(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
check(assert_type(left.div(i), "pd.Series[float]"), pd.Series, np.floating)
check(assert_type(left.div(f), "pd.Series[float]"), pd.Series, np.floating)
check(assert_type(left.div(c), "pd.Series[complex]"), pd.Series, np.complexfloating)

if TYPE_CHECKING_INVALID_USAGE:
assert_type(left.rtruediv(b), Never)
left.rtruediv(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
check(assert_type(left.rtruediv(i), "pd.Series[float]"), pd.Series, np.floating)
check(assert_type(left.rtruediv(f), "pd.Series[float]"), pd.Series, np.floating)
check(
Expand All @@ -163,7 +163,7 @@ def test_truediv_numpy_array() -> None:
)

if TYPE_CHECKING_INVALID_USAGE:
assert_type(left.rdiv(b), Never)
left.rdiv(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
check(assert_type(left.rdiv(i), "pd.Series[float]"), pd.Series, np.floating)
check(assert_type(left.rdiv(f), "pd.Series[float]"), pd.Series, np.floating)
check(
Expand Down
Loading