feat(series): truediv for bools #1314
Open
+408
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Aug 11, 2025
|
|
||
| def test_truediv_py_scalar() -> None: | ||
| """Test pd.Series[bool] / Python native scalars""" | ||
| i, f, c = 1, 1.0, 1j |
There was a problem hiding this comment.
valid to add a test with b=True in the divisor and the dividend
|
|
||
| def test_truediv_py_sequence() -> None: | ||
| """Test pd.Series[bool] / Python native sequence""" | ||
| i, f, c = [2, 3, 5], [1.0, 2.0, 3.0], [1j, 1j, 4j] |
There was a problem hiding this comment.
valid to have b = [True, False, True] here
|
|
||
| def test_truediv_numpy_array() -> None: | ||
| """Test pd.Series[bool] / numpy array""" | ||
| i = np.array([2, 3, 5], np.int64) |
There was a problem hiding this comment.
can add a b=np.array([True, False, True], np.bool_) here
|
|
||
| def test_truediv_pd_series() -> None: | ||
| """Test pd.Series[bool] / pandas series""" | ||
| i = pd.Series([2, 3, 5]) |
There was a problem hiding this comment.
I think this is the only case where you can't test b=pd.Series([True, False, True]) because it will fail at runtime in all these operations.
Ideally, it would be cool to have a if TYPE_CHECKING_INVALID_USAGE: when b is involved to see if we can catch this usage with static typing.
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| def test_truediv_py_scalar() -> None: | |||
| """Test pd.Series[float] / Python native scalars""" | |||
| i, f, c = 1, 1.0, 1j | |||
| b, i, f, c = True, 1, 1.0, 1j | |||
There was a problem hiding this comment.
in this function and other funcs in this file, you have to add the tests for b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by #1312 (comment) and a follow-up for #1311.
assert_type()to assert the type of any return value