WIP add some missing Optional type annotations #1315
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Aug 11, 2025
Comment on lines
313
to
314
| start: int = ..., | ||
| end: int = ..., | ||
| start: int | None = ..., | ||
| end: int | None = ..., |
There was a problem hiding this comment.
MarcoGorelli
commented
Aug 11, 2025
| columns: list[str] = ..., | ||
| columns: list[str] | None = ..., |
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
non-corrections
branch
from
595ca71 to
93fac58
Compare
Dr-Irv
requested changes
Aug 11, 2025
| @@ -115,7 +115,7 @@ def read_sql( | |||
| | None | |||
| ) = ..., | |||
| parse_dates: list[str] | dict[str, str] | dict[str, dict[str, Any]] | None = ..., | |||
| columns: list[str] = ..., | |||
| columns: list[str] | None = ..., | |||
There was a problem hiding this comment.
Looks like #1293 missed the defaults for read_sql(). So can you make this columns: list[str] | None = None (and below as well)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some cases where the overloads indicate that they are meant to match the parameter defaults, which in all these cases are
= None. However,Noneis currently missing from the annotations for these parametersassert_type()to assert the type of any return value