Skip to content

include missing |None in concat and read_table stubs #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2025
+52 −46
Merged

include missing |None in concat and read_table stubs #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50fa4e6
include missing `|None` in `concat` and `read_table` stubs
MarcoGorelli Aug 12, 2025
00bdbec
one more
MarcoGorelli Aug 12, 2025
f11ec72
dialect too
MarcoGorelli Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions pandas-stubs/core/reshape/concat.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def concat( # type: ignore[overload-overlap]
axis: Axis = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand All @@ -45,8 +45,8 @@ def concat( # pyright: ignore[reportOverlappingOverload]
axis: AxisIndex = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand All @@ -59,8 +59,8 @@ def concat( # type: ignore[overload-overlap]
axis: AxisIndex = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand All @@ -73,8 +73,8 @@ def concat( # type: ignore[overload-overlap] # pyright: ignore[reportOverlappin
axis: Axis = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand All @@ -87,8 +87,8 @@ def concat(
axis: Axis = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand All @@ -101,8 +101,8 @@ def concat( # type: ignore[overload-overlap]
axis: Axis = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand All @@ -115,8 +115,8 @@ def concat( # type: ignore[overload-overlap]
axis: AxisIndex = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand All @@ -132,8 +132,8 @@ def concat(
axis: Axis = ...,
join: Literal["inner", "outer"] = ...,
ignore_index: bool = ...,
keys: Iterable[HashableT2] = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] = ...,
keys: Iterable[HashableT2] | None = ...,
levels: Sequence[list[HashableT3] | tuple[HashableT3, ...]] | None = ...,
names: list[HashableT4] | None = ...,
verify_integrity: bool = ...,
sort: bool = ...,
Expand Down
66 changes: 36 additions & 30 deletions pandas-stubs/io/parsers/readers.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ def read_csv(
| Mapping[str, Callable[[str], Any]]
| None
) = ...,
true_values: list[str] = ...,
false_values: list[str] = ...,
true_values: list[str] | None = ...,
false_values: list[str] | None = ...,
skipinitialspace: bool = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] | None = ...,
skipfooter: int = ...,
nrows: int | None = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = ...,
keep_default_na: bool = ...,
na_filter: bool = ...,
verbose: bool = ...,
Expand All @@ -71,6 +71,7 @@ def read_csv(
| list[str]
| Sequence[Sequence[int]]
| Mapping[str, Sequence[int | str]]
| None
) = ...,
keep_date_col: bool = ...,
date_format: dict[Hashable, str] | str | None = ...,
Expand All @@ -89,7 +90,7 @@ def read_csv(
comment: str | None = ...,
encoding: str | None = ...,
encoding_errors: str | None = ...,
dialect: str | csv.Dialect = ...,
dialect: str | csv.Dialect | None = ...,
on_bad_lines: (
Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
) = ...,
Expand Down Expand Up @@ -118,13 +119,13 @@ def read_csv(
| Mapping[str, Callable[[str], Any]]
| None
) = ...,
true_values: list[str] = ...,
false_values: list[str] = ...,
true_values: list[str] | None = ...,
false_values: list[str] | None = ...,
skipinitialspace: bool = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] | None = ...,
skipfooter: int = ...,
nrows: int | None = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = ...,
keep_default_na: bool = ...,
na_filter: bool = ...,
verbose: bool = ...,
Expand All @@ -135,6 +136,7 @@ def read_csv(
| list[str]
| Sequence[Sequence[int]]
| Mapping[str, Sequence[int | str]]
| None
) = ...,
keep_date_col: bool = ...,
date_format: dict[Hashable, str] | str | None = ...,
Expand All @@ -153,7 +155,7 @@ def read_csv(
comment: str | None = ...,
encoding: str | None = ...,
encoding_errors: str | None = ...,
dialect: str | csv.Dialect = ...,
dialect: str | csv.Dialect | None = ...,
on_bad_lines: (
Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
) = ...,
Expand Down Expand Up @@ -182,13 +184,13 @@ def read_csv(
| Mapping[str, Callable[[str], Any]]
| None
) = ...,
true_values: list[str] = ...,
false_values: list[str] = ...,
true_values: list[str] | None = ...,
false_values: list[str] | None = ...,
skipinitialspace: bool = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] | None = ...,
skipfooter: int = ...,
nrows: int | None = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = ...,
keep_default_na: bool = ...,
na_filter: bool = ...,
verbose: bool = ...,
Expand All @@ -199,6 +201,7 @@ def read_csv(
| list[str]
| Sequence[Sequence[int]]
| Mapping[str, Sequence[int | str]]
| None
) = ...,
keep_date_col: bool = ...,
date_format: dict[Hashable, str] | str | None = ...,
Expand All @@ -217,7 +220,7 @@ def read_csv(
comment: str | None = ...,
encoding: str | None = ...,
encoding_errors: str | None = ...,
dialect: str | csv.Dialect = ...,
dialect: str | csv.Dialect | None = ...,
on_bad_lines: (
Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
) = ...,
Expand Down Expand Up @@ -246,13 +249,13 @@ def read_table(
| Mapping[str, Callable[[str], Any]]
| None
) = ...,
true_values: list[str] = ...,
false_values: list[str] = ...,
true_values: list[str] | None = ...,
false_values: list[str] | None = ...,
skipinitialspace: bool = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] | None = ...,
skipfooter: int = ...,
nrows: int | None = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = ...,
keep_default_na: bool = ...,
na_filter: bool = ...,
verbose: bool = ...,
Expand All @@ -263,6 +266,7 @@ def read_table(
| list[str]
| Sequence[Sequence[int]]
| Mapping[str, Sequence[int | str]]
| None
) = ...,
infer_datetime_format: bool = ...,
keep_date_col: bool = ...,
Expand All @@ -282,7 +286,7 @@ def read_table(
comment: str | None = ...,
encoding: str | None = ...,
encoding_errors: str | None = ...,
dialect: str | csv.Dialect = ...,
dialect: str | csv.Dialect | None = ...,
on_bad_lines: (
Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
) = ...,
Expand Down Expand Up @@ -310,13 +314,13 @@ def read_table(
| Mapping[str, Callable[[str], Any]]
| None
) = ...,
true_values: list[str] = ...,
false_values: list[str] = ...,
true_values: list[str] | None = ...,
false_values: list[str] | None = ...,
skipinitialspace: bool = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] | None = ...,
skipfooter: int = ...,
nrows: int | None = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = ...,
keep_default_na: bool = ...,
na_filter: bool = ...,
verbose: bool = ...,
Expand All @@ -327,6 +331,7 @@ def read_table(
| list[str]
| Sequence[Sequence[int]]
| Mapping[str, Sequence[int | str]]
| None
) = ...,
infer_datetime_format: bool = ...,
keep_date_col: bool = ...,
Expand All @@ -346,7 +351,7 @@ def read_table(
comment: str | None = ...,
encoding: str | None = ...,
encoding_errors: str | None = ...,
dialect: str | csv.Dialect = ...,
dialect: str | csv.Dialect | None = ...,
on_bad_lines: (
Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
) = ...,
Expand Down Expand Up @@ -374,13 +379,13 @@ def read_table(
| Mapping[str, Callable[[str], Any]]
| None
) = ...,
true_values: list[str] = ...,
false_values: list[str] = ...,
true_values: list[str] | None = ...,
false_values: list[str] | None = ...,
skipinitialspace: bool = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] = ...,
skiprows: int | Sequence[int] | Callable[[int], bool] | None = ...,
skipfooter: int = ...,
nrows: int | None = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] = ...,
na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = ...,
keep_default_na: bool = ...,
na_filter: bool = ...,
verbose: bool = ...,
Expand All @@ -391,6 +396,7 @@ def read_table(
| list[str]
| Sequence[Sequence[int]]
| Mapping[str, Sequence[int | str]]
| None
) = ...,
infer_datetime_format: bool = ...,
keep_date_col: bool = ...,
Expand All @@ -410,7 +416,7 @@ def read_table(
comment: str | None = ...,
encoding: str | None = ...,
encoding_errors: str | None = ...,
dialect: str | csv.Dialect = ...,
dialect: str | csv.Dialect | None = ...,
on_bad_lines: (
Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
) = ...,
Expand Down
Loading