remove FrozenList, type Grouper #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
approved these changes
Oct 3, 2025
Comment on lines
-50
to
+51
| def __new__(cls, *args, freq: Frequency, **kwargs) -> TimeGrouper: ... | ||
| def __new__(cls, *args: Any, freq: Frequency, **kwargs: Any) -> TimeGrouper: ... |
There was a problem hiding this comment.
I don't see that we always add Any throughout this repo - shall we do so, @Dr-Irv ?
It looks better for me, though.
There was a problem hiding this comment.
I don't see that we always add
Anythroughout this repo - shall we do so, @Dr-Irv ?
For **kwargs and *args, it's OK.
| DataFrameGroupBy as DataFrameGroupBy, | ||
| SeriesGroupBy as SeriesGroupBy, | ||
| ) | ||
| from pandas.core.indexes.frozen import FrozenList as FrozenList |
There was a problem hiding this comment.
The https://github.com/pandas-dev/pandas-stubs/ project provides type declarations for the pandas public API.
Hence we should remove FrozenList which belongs to the Internals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrozenlListisn't public, and doesn't appear in any other types. OK to just remove it?assert_type()to assert the type of any return value