Skip to content

chore(pyright): #1171 return None when possible; disable reportUnknownLambdaType #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2025
Merged

chore(pyright): #1171 return None when possible; disable reportUnknownLambdaType #1405

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0df00a
chore(pyright): #1171 remove two strict rules
cmp0xff Oct 4, 2025
7ecca2e
Merge branch 'main' into bugfix/cmp0xff/1171-update
cmp0xff Oct 4, 2025
7d3c152
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1405#di…
cmp0xff Oct 4, 2025
7a711da
fix: return None for tests
cmp0xff Oct 4, 2025
5511ced
refactor: return None by ruff
cmp0xff Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pyrightconfig-strict.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@
"enableTypeIgnoreComments": false,
"reportUnnecessaryTypeIgnoreComment": true,
"reportMissingModuleSource": true,
"useLibraryCodeForTypes": false
"useLibraryCodeForTypes": false,
"reportPrivateUsage": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep reportPrivateUsage in there. I think pyright is wrong for reporting them in stub files. Created an issue: microsoft/pyright#10992

From the test files, we will be able to fix this once pandas 3.0 is released, where there will be a pandas.api.typing.aliases which will be the supported way for people to import instead of using pandas._typing. One reason I introduced the aliases was to get around this particular warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back in 7d3c152

"reportUnknownLambdaType": false
}