refactor(ruff): switch from select to ignore

.pre-commit-config.yaml

@@ -2,14 +2,6 @@ minimum_pre_commit_version: 2.15.0
 ci:
     autofix_prs: false
 repos:
--   repo: https://github.com/psf/black
-    rev: 25.9.0
-    hooks:
-    -   id: black
--   repo: https://github.com/PyCQA/isort
-    rev: 6.0.1
-    hooks:
-    -   id: isort
 -   repo: https://github.com/astral-sh/ruff-pre-commit
     rev: v0.13.3
     hooks:
@@ -21,3 +13,11 @@ repos:
     - id: codespell
       additional_dependencies: [ tomli ]
       args: [-L, "THIRDPARTY"]
+-   repo: https://github.com/PyCQA/isort
+    rev: 6.0.1
+    hooks:
+    -   id: isort
+-   repo: https://github.com/psf/black
+    rev: 25.9.0
+    hooks:
+    -   id: black

conftest.py

@@ -1,10 +1,11 @@
+from collections.abc import Generator
 import gc
 
 import pytest
 
 
 @pytest.fixture
-def mpl_cleanup():
+def mpl_cleanup() -> Generator[None, None, None]:
     """
     Ensure Matplotlib is cleaned up around a test.
 

pandas-stubs/_libs/tslibs/__init__.pyi

@@ -1,14 +1,14 @@
 __all__ = [
-    "Period",
-    "Timestamp",
-    "Timedelta",
+    "BaseOffset",
     "NaT",
     "NaTType",
+    "OutOfBoundsDatetime",
+    "Period",
+    "Tick",
+    "Timedelta",
+    "Timestamp",
     "iNaT",
     "nat_strings",
-    "BaseOffset",
-    "Tick",
-    "OutOfBoundsDatetime",
 ]
 from pandas._libs.tslibs.nattype import (
     NaT,

pandas-stubs/_typing.pyi

@@ -1080,6 +1080,7 @@ Incomplete: TypeAlias = Any
 class Just(Protocol, Generic[T]):
     @property  # type: ignore[override]
     @override
+    # pyrefly: ignore  # bad-override
     def __class__(self, /) -> type[T]: ...
     @__class__.setter
     @override

pandas-stubs/core/arrays/categorical.pyi

@@ -114,8 +114,10 @@ class Categorical(ExtensionArray):
     ) -> Categorical: ...
     def __len__(self) -> int: ...
     def __iter__(self): ...
+    # pyrefly: ignore  # bad-param-name-override
     def __contains__(self, key) -> bool: ...
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, key: ScalarIndexer) -> Any: ...
     @overload
     def __getitem__(

pandas-stubs/core/arrays/datetimelike.pyi

@@ -71,6 +71,7 @@ class DatetimeLikeArrayMixin(ExtensionOpsMixin, ExtensionArray):
     def size(self) -> int: ...
     def __len__(self) -> int: ...
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, key: ScalarIndexer) -> DTScalarOrNaT: ...
     @overload
     def __getitem__(

pandas-stubs/core/arrays/interval.pyi

@@ -60,6 +60,7 @@ class IntervalArray(IntervalMixin, ExtensionArray):
     def __iter__(self): ...
     def __len__(self) -> int: ...
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, key: ScalarIndexer) -> IntervalOrNA: ...
     @overload
     def __getitem__(self, key: SequenceIndexer) -> Self: ...

pandas-stubs/core/arrays/sparse/array.pyi

@@ -60,6 +60,7 @@ class SparseArray(ExtensionArray, ExtensionOpsMixin):
     def unique(self): ...
     def value_counts(self, dropna: bool = True): ...
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, key: ScalarIndexer) -> Any: ...
     @overload
     def __getitem__(

pandas-stubs/core/frame.pyi

@@ -172,6 +172,7 @@ _T_MUTABLE_MAPPING = TypeVar("_T_MUTABLE_MAPPING", bound=MutableMapping, covaria
 
 class _iLocIndexerFrame(_iLocIndexer, Generic[_T]):
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, idx: tuple[int, int]) -> Scalar: ...
     @overload
     def __getitem__(self, idx: IndexingInt) -> Series: ...
@@ -189,6 +190,7 @@ class _iLocIndexerFrame(_iLocIndexer, Generic[_T]):
             | tuple[slice]
         ),
     ) -> _T: ...
+    # pyrefly: ignore  # bad-param-name-override
     def __setitem__(
         self,
         idx: (
@@ -213,6 +215,7 @@ class _iLocIndexerFrame(_iLocIndexer, Generic[_T]):
 
 class _LocIndexerFrame(_LocIndexer, Generic[_T]):
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, idx: Scalar) -> Series | _T: ...
     @overload
     def __getitem__(  # type: ignore[overload-overlap]
@@ -266,6 +269,7 @@ class _LocIndexerFrame(_LocIndexer, Generic[_T]):
     @overload
     def __getitem__(self, idx: tuple[Scalar, slice]) -> Series | _T: ...
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __setitem__(
         self,
         idx: (
@@ -291,14 +295,17 @@ class _LocIndexerFrame(_LocIndexer, Generic[_T]):
     ) -> None: ...
 
 class _iAtIndexerFrame(_iAtIndexer):
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, idx: tuple[int, int]) -> Scalar: ...
+    # pyrefly: ignore  # bad-param-name-override
     def __setitem__(
         self,
         idx: tuple[int, int],
         value: Scalar | NAType | NaTType | None,
     ) -> None: ...
 
 class _AtIndexerFrame(_AtIndexer):
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(
         self,
         idx: tuple[
@@ -310,6 +317,7 @@ class _AtIndexerFrame(_AtIndexer):
             int | StrLike | tuple[Scalar, ...],
         ],
     ) -> Scalar: ...
+    # pyrefly: ignore  # bad-param-name-override
     def __setitem__(
         self,
         idx: (

pandas-stubs/core/groupby/__init__.pyi

@@ -8,8 +8,8 @@ from pandas.core.groupby.grouper import Grouper as Grouper
 
 __all__ = [
     "DataFrameGroupBy",
-    "NamedAgg",
-    "SeriesGroupBy",
     "GroupBy",
     "Grouper",
+    "NamedAgg",
+    "SeriesGroupBy",
 ]

pandas-stubs/core/groupby/generic.pyi

@@ -204,6 +204,7 @@ class SeriesGroupBy(GroupBy[Series[S2]], Generic[S2, ByT]):
     def unique(self) -> Series: ...
     # Overrides that provide more precise return types over the GroupBy class
     @final  # type: ignore[misc]
+    # pyrefly: ignore  # bad-override
     def __iter__(  # pyright: ignore[reportIncompatibleMethodOverride]
         self,
     ) -> Iterator[tuple[ByT, Series[S2]]]: ...
@@ -448,9 +449,11 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
     ) -> Series: ...  # Series[Axes] but this is not allowed
     @property
     def dtypes(self) -> Series: ...
+    # pyrefly: ignore  # bad-param-name-override
     def __getattr__(self, name: str) -> SeriesGroupBy[Any, ByT]: ...
     # Overrides that provide more precise return types over the GroupBy class
     @final  # type: ignore[misc]
+    # pyrefly: ignore  # bad-override
     def __iter__(  # pyright: ignore[reportIncompatibleMethodOverride]
         self,
     ) -> Iterator[tuple[ByT, DataFrame]]: ...

pandas-stubs/core/indexes/datetimes.pyi

@@ -68,6 +68,7 @@ class DatetimeIndex(
         self, other: timedelta | BaseOffset
     ) -> Self: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __sub__(
         self, other: datetime | np.datetime64 | np_ndarray_dt | Self
     ) -> TimedeltaIndex: ...

pandas-stubs/core/indexes/interval.pyi

@@ -239,6 +239,7 @@ class IntervalIndex(ExtensionIndex[IntervalT, np.object_], IntervalMixin):
     @property
     def length(self) -> Index: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __getitem__(
         self,
         idx: (

pandas-stubs/core/indexes/multi.pyi

@@ -123,6 +123,7 @@ class MultiIndex(Index):
     def levshape(self): ...
     def __reduce__(self): ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __getitem__(
         self,
         idx: slice | np_ndarray_anyint | Sequence[int] | Index | MaskType,

pandas-stubs/core/indexes/period.pyi

@@ -43,6 +43,7 @@ class PeriodIndex(DatetimeIndexOpsMixin[pd.Period, np.object_], PeriodIndexField
         self, other: datetime.timedelta
     ) -> Self: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __sub__(self, other: Period) -> Index: ...
     @overload
     def __sub__(self, other: Self) -> Index: ...
@@ -55,6 +56,7 @@ class PeriodIndex(DatetimeIndexOpsMixin[pd.Period, np.object_], PeriodIndexField
         self, other: TimedeltaIndex | pd.Timedelta
     ) -> Self: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __rsub__(self, other: Period) -> Index: ...
     @overload
     def __rsub__(self, other: Self) -> Index: ...

pandas-stubs/core/indexes/range.pyi

@@ -85,6 +85,7 @@ class RangeIndex(_IndexSubclassBase[int, np.int64]):
         self, other: list[HashableT] | Index, sort: bool | None = None
     ) -> Index | Index[int] | RangeIndex: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __getitem__(
         self,
         idx: slice | np_ndarray_anyint | Sequence[int] | Index | MaskType,

pandas-stubs/core/indexes/timedeltas.pyi

@@ -56,6 +56,7 @@ class TimedeltaIndex(
     # various ignores needed for mypy, as we do want to restrict what can be used in
     # arithmetic for these types
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __add__(self, other: Period) -> PeriodIndex: ...
     @overload
     def __add__(self, other: dt.datetime | DatetimeIndex) -> DatetimeIndex: ...
@@ -64,6 +65,7 @@ class TimedeltaIndex(
         self, other: dt.timedelta | Self
     ) -> Self: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __radd__(self, other: Period) -> PeriodIndex: ...
     @overload
     def __radd__(self, other: dt.datetime | DatetimeIndex) -> DatetimeIndex: ...
@@ -75,6 +77,7 @@ class TimedeltaIndex(
         self, other: dt.timedelta | np.timedelta64 | np_ndarray_td | BaseOffset | Self
     ) -> Self: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __rsub__(
         self, other: dt.timedelta | np.timedelta64 | np_ndarray_td | BaseOffset | Self
     ) -> Self: ...
@@ -115,13 +118,15 @@ class TimedeltaIndex(
         ),
     ) -> Self: ...
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __truediv__(self, other: float | Sequence[float]) -> Self: ...
     @overload
     def __truediv__(  # pyright: ignore[reportIncompatibleMethodOverride]
         self, other: dt.timedelta | Sequence[dt.timedelta]
     ) -> Index[float]: ...
     def __rtruediv__(self, other: dt.timedelta | Sequence[dt.timedelta]) -> Index[float]: ...  # type: ignore[override]  # pyright: ignore[reportIncompatibleMethodOverride]
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __floordiv__(self, other: num | Sequence[float]) -> Self: ...
     @overload
     def __floordiv__(  # pyright: ignore[reportIncompatibleMethodOverride]

pandas-stubs/core/series.pyi

@@ -234,11 +234,13 @@ class SupportsTruedivInt(Protocol[_T_co]):
 class _iLocIndexerSeries(_iLocIndexer, Generic[S1]):
     # get item
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __getitem__(self, idx: IndexingInt) -> S1: ...
     @overload
     def __getitem__(self, idx: Index | slice | np_ndarray_anyint) -> Series[S1]: ...
     # set item
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __setitem__(self, idx: int, value: S1 | None) -> None: ...
     @overload
     def __setitem__(
@@ -272,6 +274,7 @@ class _LocIndexerSeries(_LocIndexer, Generic[S1]):
         # be s.loc[1, :], or s.loc[pd.IndexSlice[1, :]]
     ) -> Series[S1]: ...
     @overload
+    # pyrefly: ignore  # bad-param-name-override
     def __setitem__(
         self,
         idx: Index | MaskType | slice,
@@ -2208,6 +2211,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
     ) -> Series[_str]: ...
     # ignore needed for mypy as we want different results based on the arguments
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __and__(  # pyright: ignore[reportOverlappingOverload]
         self, other: bool | list[int] | MaskType
     ) -> Series[bool]: ...
@@ -3060,13 +3064,15 @@ class Series(IndexOpsMixin[S1], NDFrame):
     def __pow__(self, other: num | _ListLike | Series[S1]) -> Series[S1]: ...
     # ignore needed for mypy as we want different results based on the arguments
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __or__(  # pyright: ignore[reportOverlappingOverload]
         self, other: bool | list[int] | MaskType
     ) -> Series[bool]: ...
     @overload
     def __or__(self, other: int | np_ndarray_anyint | Series[int]) -> Series[int]: ...
     # ignore needed for mypy as we want different results based on the arguments
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __rand__(  # pyright: ignore[reportOverlappingOverload]
         self, other: bool | MaskType | list[int]
     ) -> Series[bool]: ...
@@ -3077,13 +3083,15 @@ class Series(IndexOpsMixin[S1], NDFrame):
     def __rpow__(self, other: num | _ListLike | Series[S1]) -> Series[S1]: ...
     # ignore needed for mypy as we want different results based on the arguments
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __ror__(  # pyright: ignore[reportOverlappingOverload]
         self, other: bool | MaskType | list[int]
     ) -> Series[bool]: ...
     @overload
     def __ror__(self, other: int | np_ndarray_anyint | Series[int]) -> Series[int]: ...
     # ignore needed for mypy as we want different results based on the arguments
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __rxor__(  # pyright: ignore[reportOverlappingOverload]
         self, other: bool | MaskType | list[int]
     ) -> Series[bool]: ...
@@ -4244,6 +4252,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
     rdiv = rtruediv
     # ignore needed for mypy as we want different results based on the arguments
     @overload  # type: ignore[override]
+    # pyrefly: ignore  # bad-override
     def __xor__(  # pyright: ignore[reportOverlappingOverload]
         self, other: bool | MaskType | list[int]
     ) -> Series[bool]: ...

pandas-stubs/testing.pyi

@@ -8,6 +8,6 @@ from pandas._testing import (
 __all__ = [
     "assert_extension_array_equal",
     "assert_frame_equal",
-    "assert_series_equal",
     "assert_index_equal",
+    "assert_series_equal",
 ]