Conversation
|
@Dr-Irv I am tagging you because this PR changes NoDefaultDoNotUse. Thank you. |
|
@loicdiridollou I approved/merged #1664 so I think you need to merge again with |
|
Thanks for the feedback, this is cleaned up and ready for a new look! |
| "sem", | ||
| "size", | ||
| "skew", | ||
| "kurt", |
There was a problem hiding this comment.
Added the tests, the release notes says that it also works on apply but neither the docs nor the stubs allow for str passed to apply so i will maintain that convention and only test agg and transform.
There was a problem hiding this comment.
I think it makes sense to test all Literals here at the same place. Postponed to #1671
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you @loicdiridollou !
| "sem", | ||
| "size", | ||
| "skew", | ||
| "kurt", |
There was a problem hiding this comment.
I think it makes sense to test all Literals here at the same place. Postponed to #1671
pipeoperations topandas.api.typing.Rollinginstances pandas#57076)