Skip to content

GH1654 Pipe method#1665

Merged
cmp0xff merged 5 commits intopandas-dev:mainfrom
loicdiridollou:gh1654_pipe
Feb 10, 2026
Merged

GH1654 Pipe method#1665
cmp0xff merged 5 commits intopandas-dev:mainfrom
loicdiridollou:gh1654_pipe

Conversation

@cmp0xff cmp0xff requested a review from Dr-Irv February 7, 2026 07:21
@cmp0xff
Copy link
Contributor

cmp0xff commented Feb 7, 2026

@Dr-Irv I am tagging you because this PR changes NoDefaultDoNotUse. Thank you.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 9, 2026

@loicdiridollou I approved/merged #1664 so I think you need to merge again with main, and then I think @cmp0xff can do the review

@loicdiridollou
Copy link
Member Author

Thanks for the feedback, this is cleaned up and ready for a new look!

"sem",
"size",
"skew",
"kurt",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it tested somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the tests, the release notes says that it also works on apply but neither the docs nor the stubs allow for str passed to apply so i will maintain that convention and only test agg and transform.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to test all Literals here at the same place. Postponed to #1671

Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @loicdiridollou !

"sem",
"size",
"skew",
"kurt",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to test all Literals here at the same place. Postponed to #1671

@cmp0xff cmp0xff merged commit 6bc10ad into pandas-dev:main Feb 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants