GH1654 Numeric changes for 3.0#1667
Open
loicdiridollou wants to merge 8 commits intopandas-dev:mainfrom
Open
Conversation
loicdiridollou
force-pushed
the
gh1654_numeric
branch
from
bdacef9 to
7ae5f79
Compare
cmp0xff
requested changes
Feb 9, 2026
pandas-stubs/core/frame.pyi
Outdated
| method: Literal["pearson", "kendall", "spearman"] = "pearson", | ||
| numeric_only: _bool = False, | ||
| min_periods: int | None = None, | ||
| ) -> Series: ... |
Contributor
There was a problem hiding this comment.
Can it actually be always float?
Suggested change
| ) -> Series: ... | |
| ) -> Series[float]: ... |
pandas-stubs/core/series.pyi
Outdated
| self, | ||
| arg: Callable[[S1], S2 | NAType] | Mapping[S1, S2] | Series[S2], | ||
| arg: Callable[Concatenate[S1, ...], S2 | NAType], | ||
| na_action: Literal["ignore"] = ..., |
Contributor
There was a problem hiding this comment.
Suggested change
| na_action: Literal["ignore"] = ..., | |
| na_action: Literal["ignore"] = "ignore", |
Member
Author
There was a problem hiding this comment.
The default is None so I will remove the ... and add the default where it needs to
Member
Author
There was a problem hiding this comment.
Technically the default is None but that would break a couple of things, let me take a deeper look here, will mark it as draft for a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numeric_onlytoDataFrame.cum*methods pandas#53072)Series.mappandas#59814)